Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REST API request]: Variations are being requested when loading product editor #47359

Closed
octaedro opened this issue May 10, 2024 · 0 comments · Fixed by #47360
Closed

[REST API request]: Variations are being requested when loading product editor #47359

octaedro opened this issue May 10, 2024 · 0 comments · Fixed by #47360
Assignees
@octaedro
Labels
focus: new product ux revamped product management experience team: Mothra type: enhancement The issue is a request for an enhancement.

Comments

@octaedro
Copy link
Contributor

octaedro commented May 10, 2024 •
edited

When we see a variable product, we always make the REST API request to get the variations. That's not optimal because we want to load them only when we will show/use them.

We made some progress in PR 46963, preventing that call from being made if the product is not variable.

We should make the REST API request only when we need the product variations (under the Variations tab).

Screenshot 2024-05-10 at 9 48 59 AM
@octaedro octaedro added type: enhancement The issue is a request for an enhancement. focus: new product ux revamped product management experience team: Mothra labels May 10, 2024
@octaedro octaedro self-assigned this May 10, 2024
@octaedro octaedro mentioned this issue May 10, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@octaedro octaedro

Labels
focus: new product ux revamped product management experience team: Mothra type: enhancement The issue is a request for an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Request variations conditionally woocommerce/woocommerce
1 participant
@octaedro