Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@wordpress/icons package isn't extract from the bundle #47365

Closed
gigitux opened this issue May 10, 2024 · 1 comment
Closed

@wordpress/icons package isn't extract from the bundle #47365

gigitux opened this issue May 10, 2024 · 1 comment
Labels
package: dependency-extraction-webpack-plugin issues related to @woocommerce/dependency-extraction-webpack-plugin

Comments

@gigitux
Copy link
Contributor

gigitux commented May 10, 2024

With DependencyExtractionWebpackPlugin webpack plugin, we should extract all the @wordpress/* dependencies. I noticed that this doesn't happen for the @wordpress/icons package:

image

Related discussion: p1715337777088849-slack-C03CPM3UXDJ

I noticed this beavhiour on the WooCommerce Admin project, but it could make sense to inspect other projects as well.
@gigitux gigitux added the package: dependency-extraction-webpack-plugin issues related to @woocommerce/dependency-extraction-webpack-plugin label May 10, 2024
@gigitux
Copy link
Contributor Author

gigitux commented May 13, 2024

I'm going to close this issue because @chihsuan pointed out that WordPress core doesn’t ship with the icons package!

@gigitux gigitux closed this as completed May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package: dependency-extraction-webpack-plugin issues related to @woocommerce/dependency-extraction-webpack-plugin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gigitux