front: hook popups to browser's history api #473
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wukko
requested changes
Apr 30, 2024
There was a problem hiding this comment.
going back closes all popups instead of going to previous state on desktop in chrome, and as i assume mobile chrome uses same way of navigation. not sure what this pr is supposed to do.
i think a better way to implement history would be to do page links like /settings/audio, which would also be retained across page refreshes.
|
system's back button behaving the same as the popup's back button (which currently closes all popups) felt more intuitive, but I can implement popup tab history if you think that this approach is better. popup urls would require a bit of frontend server rewriting, which i'm up for, but i'm not sure if it's worth it judging by the progress made on the svelte rewrite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as stated in #410, this makes cobalt feel a little bit more native. also possibly reduces user frustration by avoiding the situation where using system's back button closes the app trying instead of closing popups.
closes #410