Possible bug in inlineSelectionsFromInlineFragments.go

[jiajun-brex]

hello, we are evaluating cosmo and one of our complex query which involves inline fragment and @include failed. I am able to pin point to a possible issue in inlineSelectionsFromInlineFragments.go

I tried a test case in inlineSelectionsFromInlineFragments.go

	t.Run("with nested compatible fragments with @include", func(t *testing.T) {
		run(t, inlineSelectionsFromInlineFragments, testDefinition, `
					{
						pet {
							... on Dog {
								... on Dog {
									owner {
										name
									}
								}
								... on Dog @include(if: $includeName){
									nickname
								}
							}
						}
					}`,
			`
					{
						pet {
							... on Dog {
								owner {
									name
								}
							}
							... on Dog @include(if: $includeName){
								nickname
							}
						}
					}`)
	})

However this failed with the following, you can notice the mismatched paranthesis, this causes more selection set issues in the normalization process after this operation

Error:      	Not equal: 
        	            	expected: "{pet {... on Dog {owner {name}} ... on Dog @include(if: $includeName){nickname}}}"
        	            	actual  : "{pet {... on Dog {owner {name} ... on Dog @include(if: $includeName){nickname}}}}"

[jensneuse]

It seems like $includeName is not defined in your query.

[jiajun-brex]

It fails even I add them it seems

	t.Run("with nested compatible fragments with @include", func(t *testing.T) {
		run(t, inlineSelectionsFromInlineFragments, testDefinition, `
					query test($includeName: Boolean) {
						pet {
							... on Dog {
								... on Dog {
									owner {
										name
									}
								}
								... on Dog @include(if: $includeName){
									nickname
								}
							}
						}
					}`,
			`
					query test($includeName: Boolean) {
						pet {
							... on Dog {
								owner {
									name
								}
							}
							... on Dog @include(if: $includeName){
								nickname
							}
						}
					}`)
	})

with results

Expected :query test($includeName: Boolean){pet {... on Dog {owner {name}} ... on Dog @include(if: $includeName){nickname}}}
Actual   :query test($includeName: Boolean){pet {... on Dog {owner {name} ... on Dog @include(if: $includeName){nickname}}}}

[jensneuse]

Can you try this again on the latest version and re-open the issue if it's not solved? Thanks

[jiajun-brex]

Thanks, this one is resolved and confirmed not an issue any more!
(Though I found another potential bug in testing, cut an issue #814)