Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to use CEF in universal macOS binaries #24393

Open
vadz opened this issue Mar 10, 2024 · 2 comments
Open

Make it possible to use CEF in universal macOS binaries #24393

vadz opened this issue Mar 10, 2024 · 2 comments
Labels
macOS Specific to Cocoa macOS port

Comments

@vadz
Copy link
Contributor

vadz commented Mar 10, 2024

Right now this fails because building under x64 builds x64-only CEF wrapper (and downloads x64 version of CEF shared library), so linking doesn't find arm64 symbols.

I hope it is possible to use CEF in this case because Chrome itself does come up as a universal binary under Mac, but right now I don't really know how to do it: should we download both files and manually lipo all the shared libraries together?

And what about the support files, apparently at least the snapshot one is architecture-specific?

Any thoughts/hints would be welcome!

@vadz vadz added the macOS Specific to Cocoa macOS port label Mar 10, 2024
@vadz
Copy link
Contributor Author

vadz commented Mar 11, 2024

I don't see any other way than using lipo manually, CEF CMake makefiles explicitly override CMAKE_OSX_ARCHITECTURES and set it to CMAKE_HOST_SYSTEM_PROCESSOR, so we can't even build the wrapper library as a universal one.

I'll try to do this in my baby-cmake...

@vadz
Copy link
Contributor Author

vadz commented Mar 15, 2024

Without much surprise, my CMake-fu failed me, but I could at least create #24402 which solves this is another way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macOS Specific to Cocoa macOS port
Projects
None yet
Development

No branches or pull requests

1 participant