Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline UITraitChangeObservable in implementing classes #20265

Open
rolfbjarne opened this issue Mar 6, 2024 · 0 comments
Open

Inline UITraitChangeObservable in implementing classes #20265

rolfbjarne opened this issue Mar 6, 2024 · 0 comments
Milestone

Comments

@rolfbjarne
Copy link
Member

This is a follow-up to #19410.

We need to inline the members of the UITraitChangeObservable interface into implementing types (UIView, UIViewController, UIPresentationController, UIWindowScene). This turned out a bit cumbersome to implement, because C# doesn't support calling the default interface member from an actual implementing member (#13294 (comment)).

Here's the current WIP: rolfbjarne@5e09575 / https://github.com/rolfbjarne/xamarin-macios/commits/uitraitchangeobservable-inlined-edition

This is probably much easier to do once we've added support for default interface members (#13294), so postpone until then.

@rolfbjarne rolfbjarne added this to the Future milestone Mar 6, 2024
@rolfbjarne rolfbjarne changed the title Inline Inline UITraitChangeObservable in implementing interfaces Mar 6, 2024
@rolfbjarne rolfbjarne changed the title Inline UITraitChangeObservable in implementing interfaces Inline UITraitChangeObservable in implementing classes Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant