Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for CryptoTokenKit #7876

Open
martinscholz83 opened this issue Feb 12, 2020 · 12 comments · May be fixed by #20587
Open

Support for CryptoTokenKit #7876

martinscholz83 opened this issue Feb 12, 2020 · 12 comments · May be fixed by #20587
Assignees
@rolfbjarne
Labels
enhancement The issue or pull request is an enhancement iOS Issues affecting Xamarin.iOS macOS Issues affecting Xamarin.Mac
Milestone
Future

Comments

@martinscholz83
Copy link

Are there any plans when Xamarin.Mac supports the new CryptoTokenKit API. Currently we have to build with Sharpie.
@chamons chamons added enhancement The issue or pull request is an enhancement iOS Issues affecting Xamarin.iOS macOS Issues affecting Xamarin.Mac labels Feb 13, 2020
@chamons chamons added this to the Future milestone Feb 13, 2020
@chamons
Copy link
Contributor

chamons commented Feb 13, 2020

The fact that we are missing this binding shows up in our binding todos:

https://gist.github.com/chamons/b74a1133a44143c13ea438febbb9e2da

I don't have a timetable right now to give you, but this is on our radar.

@chamons
Copy link
Contributor

chamons commented Feb 13, 2020

I'm not sure if you were using my "instructions" in https://github.com/chamons/mac-samples/tree/master/SystemFrameworkBinding

Part of what makes this framework non-trivial is that you need specific hardware to test.

@martinscholz83
Copy link
Author

Yeap, that the is the one I'm using. What you mean with special hardware? We have lot of different PIV tokens from Feitian, Yubico or Gemalto we could test with. Is this what you mean with hardware?

@martinscholz83
Copy link
Author

I'm trying to get a Dev cert from Apple to add in VS to enable the com.apple.security.smartcard entitlement. Because currently I'm getting Null when trying to get TKSmartCardSlotManager.DefaultManager.

@chamons
Copy link
Contributor

chamons commented Feb 13, 2020

You will likely need to add com.apple.security.smartcard by hand to your entitlement, as there is not IDE support to my knowledge.

@martinscholz83
Copy link
Author

That’s what I meant with add it to VS :o)

@martinscholz83
Copy link
Author

I'm currently have a problem using the API. I'm trying to send some simple verify pin commands to a YubiKey. Here is my sample code

card.BeginSessionWithReply((bool reply, NSError error) =>
                {
                    if (reply)
                    {
                        List<Byte> _AID_PIV = new List<byte> { 0xa0, 0x00, 0x00, 0x03, 0x08 };
                        List<byte> apdu = new List<byte> { 0x00, 0xA4, 0x04, 0x00, (byte)(_AID_PIV.Count), 0x00 };
                        apdu.InsertRange(5, _AID_PIV);

                        card.TransmitRequest(NSData.FromArray(apdu.ToArray()), (NSData data, NSError error) =>
                        {
                            if (error == null)
                            {
                                List<byte> pin = new List<byte> { 0x31, 0x32, 0x33, 0x34, 0x35, 0x36, 0x37, 0x38 };
                                List<byte> apduVerify = new List<byte> { 0x00, 0x20, 0x00, 0x80, 0x08, 0x00 };
                                apduVerify.InsertRange(5, pin);

                                card.TransmitRequest(NSData.FromArray(apduVerify.ToArray()), (NSData data, NSError error) =>
                                {
                                    if (error == null)
                                    {
                                        if (data != null)
                                            // Do something with data
                                    }
                                    else
                                    {
                                        // Do something with error
                                    }
                                });                                
                            }
                        });                        
                    }
                });

The native functions BeginWithSessionReply and TransmitRequest are using some kind completionHandler, closures which are mapped to Action<type, type>. Unfortunately these Actions never called, except you debug the code and wait long enough for it. I also tried with Task.Run... but that didn't helped. Do you have any idea how to make theses closures awaitable?

@chamons
Copy link
Contributor

chamons commented Mar 18, 2020

Where is that code being run from? Do you have something running a message pump (such as a NSApplication/UIApplication)?

@martinscholz83
Copy link
Author

It's running in normal NSViewController (simple UI/Window project)

@martinscholz83
Copy link
Author

I tried with semaphore like in this example. But that didn't helper either.

@martinscholz83
Copy link
Author

i think the signature

// -(void)beginSessionWithReply:(void (^ _Nonnull)(BOOL, NSError * _Nullable))reply;
[Export ("beginSessionWithReply:")]
void BeginSessionWithReply (Action<bool, NSError> reply);

needs to be something like

Func<bool, NSError, Task> reply

@dotMorten
Copy link

I just hit this missing binding hard today too. This prevents us from doing any CAC card support on iOS/Catalyst.

rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue May 8, 2024
@rolfbjarne
[CryptoTokenKit] Bind this framework. Fixes xamarin#7876.
91a6ee5 
Fixes xamarin#7876.
@rolfbjarne rolfbjarne linked a pull request May 8, 2024 that will close this issue
Open
@rolfbjarne rolfbjarne self-assigned this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rolfbjarne rolfbjarne

Labels
enhancement The issue or pull request is an enhancement iOS Issues affecting Xamarin.iOS macOS Issues affecting Xamarin.Mac
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

[CryptoTokenKit] Bind this framework. Fixes #7876. rolfbjarne/xamarin-macios
4 participants
@rolfbjarne @dotMorten @chamons @martinscholz83