Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funscripts with optional metadata tags can block heatmap generation #1734

Closed
Mellified opened this issue May 18, 2024 · 1 comment · Fixed by #1742
Closed

Funscripts with optional metadata tags can block heatmap generation #1734

Mellified opened this issue May 18, 2024 · 1 comment · Fixed by #1742

Comments

@Mellified
Copy link

The funscript metadata section can include a "Version" tag, which by convention is a floating point number. When xbvr tries to generate a heatmap for a funscript which includes "Version":1.0 it will fail with an error:

level=warning msg="json: cannot unmarshal number into Go struct field Script.version of type string"

This is a valid tag, and should be processed. But rather than fixing this specific problem the more general case should be solved. Any problems with optional tags should be ignored, rather than causing the heatmap generation process to fail.

@Mellified
Copy link
Author

Note that SLR uses a version tag in its AI generated scripts at the top level of the JSON file. This tag does not block funscript generation in xbvr. It is only when the version tag is included in the Metadata section of the funscript JSON when the problem occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant