Fixed processing exit signals and exit exception #5399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 6, 2024 22:06
anki-code
changed the title
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
anki-code
changed the title
anki-code
changed the title
jnoortheen
reviewed
May 7, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
|
I moved the comment to the original issue - #5381 (comment). |
for more information, see https://pre-commit.ci
|
Fixed stty state. @jnoortheen @gforsyth ready to review. |
|
The new revision is working for me. Xonsh is now accepting exit signals and exiting properly. |
gforsyth
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
Case 1: Handler catches the exit signal and do not pass it forward. As result xonsh could be suspended by OS or crash. Also exit code is wrong. See repeatable examples with SIGHUP in #5381 (comment).
Case 2: From bash/zsh as login shell run xonsh. Then send quit signal to xonsh. The terminal state will be broken: disabled SIGINT, mouse pointer produces mouse state codes.
After
Case 1: Xonsh exit normally with right exit code. Fixed #5381 #5304 #5371.
Case 2: After exiting with right exit code the state of the terminal is good.
For community
⬇️ Please click the 👍 reaction instead of leaving a
+1or 👍 comment