Global search missing in languages other than English on MacOS (regression)

[rolandlo]

Operating System

Mac OS

(Linux only) Distribution

No response

(Linux only) Desktop Environment

No response

(Linux Only) Display Server

None

Installation Method

built from source

Xournal++ Version

master

libgtk Version

3.24.38

Bug Description

On MacOS there is a global search in the help menu.

Since commit 2cc386f Merge Crowdin updates however the global search is only available when the language is set to English, not with other languages.

Interestingly when I change the menu name in another language from the translated string back to "_Help" it works again.
So this patch fixes the issue (not in the desired way, but anyway) for the German language.

diff --git a/po/de.po b/po/de.po
index eb0cfc7f9..1a9688abc 100644
--- a/po/de.po
+++ b/po/de.po
@@ -4132,7 +4132,7 @@ msgstr "Pausieren"
 
 #: ../ui/mainmenubar.xml:855
 msgid "_Help"
-msgstr "_Hilfe"
+msgstr "_Help"
 
 #: ../ui/mainmenubar.xml:859
 msgid "Help"

Expected Behaviour

I would expect global search for all languages on MacOS.

Steps to Reproduce

1. Run xournalpp on MacOS
2. Open menu Help (translated) and observe that it only shows the global search if the menu is called "Help" (i.e. it is not translated)

Additional Context

No response

[bhennion]

Just out of curiosity, what does this searchbar allow you to search for?

[rolandlo]

It allows to search for menu entries in first place (kind of like HUD). See https://support.apple.com/de-ch/guide/mac-help/hlpvw003/mac
We could also create and install an Apple help book for further help, see https://wiki.lazarus.freepascal.org/Add_an_Apple_Help_Book_to_your_macOS_app and https://www.youtube.com/watch?v=8fxCR7WaMWQ