Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependent metric equality is fragile on new ProtocolMetricImpl #1236

Open
michael-mclawhorn opened this issue Mar 1, 2022 · 0 comments
Open

Comments

@michael-mclawhorn
Copy link
Contributor

1st- The static reference to this.dependentMetrics can be overshadowed in suprising ways in subclasses through the static inclusion.
2nd - Equality on dependent metrics is so strict as to be problematic for testing and any kind of proxying. It should be sufficient to note that the dependent metric names are identical strongly indicating the same meaning with less test burden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant