Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mods broken since 4.11.12 #11613

Open
1 task done
richcb opened this issue May 17, 2024 · 5 comments
Open
1 task done

Mods broken since 4.11.12 #11613

richcb opened this issue May 17, 2024 · 5 comments
Labels

Comments

@richcb
Copy link

richcb commented May 17, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Game Version

4.11.12

Describe the bug

Since updating to game version 4.11.12, my mods have disappeared from the mod menu. Attempting to download mods, I receive the error "Could not download mod list". Attempting to download directly from a url did not work either.

Rolling back to 4.11.11 did not resolve the issue.

Steps to Reproduce

  1. Install 4.11.12
  2. Click on 'Mods'
  3. Receive error message

Screenshots

Screenshot_20240516_175142_Unciv

Link to save file

No response

Operating System

Android

Additional Information

No response

@richcb richcb added the bug label May 17, 2024
@SomeTroglodyte
Copy link
Collaborator

updating to game version 4.11.12

How? Source? Signature change? Did it ask you to uninstall first because of incompatible sources?

Do you have root file manager, or an Android Studio Device Explorer connection, or maybe logcat access? Knowing what actually exists in the game's local folder might give a hint, or seeing the logcat messages on startup.

As an extreme measure (unless up there "uninstall" was a yes) - app info, storage, clear storage: Loses all mods, save games and settings, but if that were to help, then we would know there was some data it couldn't cope with, maybe from an interrupted mod install - or a defective mod with an illegal ModOptions json...

In other words, I don't believe the version is at fault until irrefutably proven..

@yairm210
Copy link
Owner

I could not replicate this either
We could make these failures copy the stack trace to clipboard for debugging... would be interesting to see

@richcb
Copy link
Author

richcb commented May 19, 2024

I installed from the compiled apk available to download here on github via releases. I don't believe mods were corrupted, as they were working fine prior to version update. (Rekmod, Absolute Units, Absolute Units XL)

Do you have root file manager, or an Android Studio Device Explorer connection, or maybe logcat access?

I don't have a rooted device or logcat, AFAIK. I can try a total wipe and clean install. I will come back with results

@richcb richcb closed this as completed May 19, 2024
@richcb
Copy link
Author

richcb commented May 19, 2024

I did not mean to mark closed and don't seem to have an option to undo. I will attempt clean install and return

@SomeTroglodyte
Copy link
Collaborator

apk from releases

Both before and after "Since updating to game version 4.11.12" I assume? That is, you got 4.11.12 from gihub releases, but the version you replaced - was it a github release too? Probably, otherwise it would have triggered what I meant with "Did it ask you to uninstall first because of incompatible sources" and you didn't mention - but still, please confirm.

I'm insisting because we've had reports of file access problems on the very first start on Android - those were related to the SaveGames folder missing which should be autocreated but maybe didn't. And such a non-"update" due to signature change would count as fresh install for that purpose...

So maybe - what if - your mod manager didn't start to query github and thus listed nothing - because it wanted to look into already installed mods first, of course at that point the mods folder is still missing - normally not a reason for an exception that stops the rest of the workflow, but if that elusive first-launch bug hit???

Hey - maybe it's just that: this and that SaveGames bug only hit when Unciv is launched on a very recent Android from the package installer's open offer - because of their new security crap fantasies?

So please also update "Operating System: Android" with an as exactly as possible specified Android version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants