Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod checker reports some problems with texture atlases or their source images #11620

Merged
merged 2 commits into from
May 21, 2024

Conversation

SomeTroglodyte
Copy link
Collaborator

Closes #11618 - see screenshot there at the end.

That mod has a few corrupt png images - their bits are webp and do not match the extension. Thus, gimp loads them without any complaint (as it rightfully ignores the extension), but TexturePacker fails (it has no webp handler), but the modder is stumped (I see no bad files)... Now they can see the innermost cause message that Gdx throws. Which is surprisingly accurate.

For that check to run, the ImagePacker run must have failed - only then will RulesetValidator run a full scan for any bad png's.

@yairm210 yairm210 merged commit 65b519c into yairm210:master May 21, 2024
3 checks passed
@SomeTroglodyte SomeTroglodyte deleted the PackerErrors branch May 21, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Atlas and game.png file generation should make exceptions accessible to a Modder
2 participants