Make failed on Redhat 8

[qin-nz]

Run make, then

util/status.cc: In static member function ‘static const char* rocksdb::Status::CopyState(const char*)’:
util/status.cc:28:15: error: ‘char* strncpy(char*, const char*, size_t)’ output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-truncation]
   std::strncpy(result, state, cch - 1);
   ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
util/status.cc:19:18: note: length computed here
       std::strlen(state) + 1; // +1 for the null terminator
       ~~~~~~~~~~~^~~~~~~
cc1plus: all warnings being treated as errors
make[2]: *** [Makefile:1879: util/status.o] Error 1
make[2]: Leaving directory '/home/jc/ardb/deps/rocksdb-5.14.2'
make[1]: *** [Makefile:401: /home/jc/ardb/src/../deps/rocksdb-5.14.2/librocksdb.a] Error 2
make[1]: Leaving directory '/home/jc/ardb/src'
make: *** [Makefile:4: all] Error 2

gcc version 8.2.1 20180905 (Red Hat 8.2.1-3) (GCC)

[chadlyon]

I created a PR for this: #479

[chadlyon]

Closing PR #479 since you can actually get around this by doing

make CXX='g++ -Wno-error=stringop-truncation'

[chadlyon]

In fact you will also need to add -Wno-error=format-truncation and -Wno-error=class-memaccess for ardb compile as well.

[stevedh]

This also occurs in Ubuntu 21 which has gcc 10.3.0. I agree it can be worked around with those error directives. I am not sure that is the right solution or if there is really an issue here that the compiler is detecting. However this should definitely remain open from what I can tell.