Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong kernel sizes in the JDC model #214

Open
Rifur13 opened this issue Mar 11, 2024 · 1 comment
Open

Wrong kernel sizes in the JDC model #214

Rifur13 opened this issue Mar 11, 2024 · 1 comment

Comments

@Rifur13
Copy link

Rifur13 commented Mar 11, 2024

It looks like the JDC model is implemented incorrectly. The comments don't reflect the shapes of the actual tensors, and the input to the first LSTM layer is of shape (b * 8, 31, 512) which I assum is wrong.

The wrong kernel size is used in the ResBlock layer. It's (1, 2), but should be (1, 4).
The original implementation has a kernel of (1, 4).

It looks like a bug, please help me understand if it is.

@hyzhan
Copy link

hyzhan commented Mar 12, 2024

Maybe the audio is too short.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants