Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

animations #1121

Open
absolutelynothelix opened this issue Sep 2, 2023 · 24 comments
Open

animations #1121

absolutelynothelix opened this issue Sep 2, 2023 · 24 comments
Labels
discussion Not a bug feature Feature request help wanted SOMEBODY PLEASE HELP
Milestone

Comments

@absolutelynothelix
Copy link
Collaborator

absolutelynothelix commented Sep 2, 2023

since there are multiple open issues requesting animations i decided to group them into a single issue to have a more or less centralized discussion, ease the progress tracking and reduce the amount of open issues.

there is also a thread in the #development channel on the discord server to ease the communication between developers interested in implementing animations.

feel free to reserve one of the first posts in this issue if you're interested in structuring it even more.

related issues:

related discussions:

  • todo.

related pull requests:

forks that implement animations:

  • todo.

feel free to post here or ping me on the discord server about additions to the lists above.

@ghost
Copy link

ghost commented Sep 2, 2023

Forks that implements animation:
https://github.com/pijulius/picom (Best animation)
https://github.com/jonaburg/picom {Slight animation changes}
https://github.com/FT-Labs/picom (Intended for his own fork of dwm)
https://github.com/fdev31/picom (Fork of FT-Labs Picom which somewhat work better than FT-Labs picom)
Thats all i can remember lol

@dccsillag
Copy link

dccsillag commented Sep 2, 2023

... and mine, https://github.com/dccsillag/picom, which is what pijulius, FT-Labs and fdev31 forked from (and what the long-standing PR #772 was from).

@ghost
Copy link

ghost commented Sep 3, 2023

Oh yeah i kinda forgot about yours.... Thanks for reminding me though :D

@NotMurPh
Copy link

NotMurPh commented Sep 22, 2023

i can't check out the discord thread, looks like the invitation link has expired! i would be happy to hear an update about picom animations 🫠

@absolutelynothelix
Copy link
Collaborator Author

i can't check out the discord thread, looks like the invitation link has expired!

thanks for pointing out. i copied it from the discord badge in the readme but it turned out that it wasn't updated when it was changed so i updated it both in the readme and here.

i would be happy to hear an update about picom animations 🫠

unfortunately, there are no updates.

@allusive-dev
Copy link

allusive-dev commented Oct 3, 2023

Still want animation support.

Done.

Here is my public, actively maintained, on the AUR fork of pijulius picom.

Now on NixOS and Nixpkgs and I am always looking to add new features.

Links:

https://github.com/allusive-dev/picom-allusive
https://wiki.archlinux.org/title/Picom_Allusive
https://aur.archlinux.org/packages/picom-allusive
NixOS

@yshui
Copy link
Owner

yshui commented Dec 26, 2023

Hi, I want to quickly ( 🤞 ) merge animation support after v11 release (which should be in the next few weeks, again 🤞 ).

looks like @FT-Labs' fork is the most comprehensive one? so maybe i will consolidate all the PR's around that.

now, I realized I never asked if @FT-Labs wants to merge their branch into this repo, i just assumed they do 😅 I will still do this either way (these are all open source after all), but if @FT-Labs wants to, we can work together and sort this all out faster than I can with only current picom developers.

@yshui
Copy link
Owner

yshui commented Dec 26, 2023

And if @FT-Labs's fork has missing features, or there is another fork I need to look at, or something, please leave a comment.

@yshui
Copy link
Owner

yshui commented Dec 26, 2023

And I would definitely appreciate @dccsillag's help as well if he has more time and is able to.

@FT-Labs
Copy link

FT-Labs commented Dec 28, 2023

Hello @yshui,

Yes, I'm totally up for it. That would be great, because this is a work that needs more than 1 person. Any help would be appreciated, I would be glad to explain what I have done until now and explain all of the steps.

@jasper-at-windswept
Copy link

jasper-at-windswept commented Jan 12, 2024

@yshui
I've forked the next branch and implemented the animations from Compfy which came from pijulius which are modified from dccsilag.
If you want me to make a PR let me know.
https://github.com/jasper-at-windswept/picom

@dccsillag
Copy link

dccsillag commented Jan 12, 2024

And I would definitely appreciate @dccsillag's help as well if he has more time and is able to.

I'd be happy to help. (Still a bit strained for time, though!)

@zeorin
Copy link

zeorin commented Jan 14, 2024

I tried out @jasper-at-windswept's fork because I was curious, and the animations are cool, but the following would need some work, imo:

  • interaction with shaders, currently the shader is unapplied and then only reapplies a bit after the animation has finished.
  • interaction with blur and shadows, currently the shadows lag behind the actual window's animation and the space in between blurred.
  • interaction with mouse-driven changes to window position and size

It would also be great to be able to set all animation settings using rules, rather than only being able to exclude windows from opening and unmapping animations. This would allow one tweak animations in a very fine-grained way, it'd be great for e.g. menus, docks, launchers, notifications, etc.

Here is a recording (i3wm):

picom-animations.mp4

For reference, my config is here: https://github.com/zeorin/dotfiles/blob/07f0c9bf789f8baebc40afd3b06c5586b7a0caf8/home-manager/home.nix#L2618-L2803

@yshui
Copy link
Owner

yshui commented Jan 14, 2024

@jasper-at-windswept I intend to take from @FT-Labs 's fork, as IIUC it is the most up-to-date version.

@yshui
Copy link
Owner

yshui commented Jan 14, 2024

Hello @yshui,

Yes, I'm totally up for it. That would be great, because this is a work that needs more than 1 person. Any help would be appreciated, I would be glad to explain what I have done until now and explain all of the steps.

Hi, can you open a PR from your branch?

@jasper-at-windswept
Copy link

@jasper-at-windswept I intend to take from @FT-Labs 's fork, as IIUC it is the most up-to-date version.

No problem. Looking forward to animations in v11!

@DarioDarko

This comment was marked as off-topic.

@XoDefender
Copy link

Also feel free to try out my fork, it is based on FT-Labs and has animation customization throughout: rules, xprop, wintypes. May be helpful to take particular parts from it (https://github.com/XoDefender/picom)

@Mateoo303
Copy link

@XoDefender your fork is really awesome! I gave it a star. There is only one problem with it. It has a bug: when only one window is opened on workspace then it doesn't have rounded corenes. As soon as I open another window corners become rounded. I would really appreciate it if you could fix it.

@XoDefender

This comment was marked as off-topic.

@Mateoo303

This comment was marked as off-topic.

@kashyap-akash
Copy link

kashyap-akash commented Apr 20, 2024

I've been using this fork of picom for a long time and it has a lot of good animations, and it's really light weight.
https://github.com/allusive-dev/compfy

A little preview

compfy-2024-04-20_21.55.36.mp4

@yshui
Copy link
Owner

yshui commented May 17, 2024

hi, can anyone give the new animation PR a try? #1253

@Icy-Thought
Copy link

@yshui managed to fix the issue I was facing earlier and now the animations works as intended! And what I have to say is that they are as smooth as it gets. No hiccups as of now and I am digging the appear/disappear animation! xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Not a bug feature Feature request help wanted SOMEBODY PLEASE HELP
Projects
None yet
Development

No branches or pull requests