{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":105944401,"defaultBranch":"master","name":"yugabyte-db","ownerLogin":"yugabyte","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2017-10-05T21:56:00.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/17074854?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1716436594.0","currentOid":""},"activityList":{"items":[{"before":"f1f4a4709a5fa12d41553aece124bcc41d1551a1","after":"8eda252b6b950448109ed8a0e63a509ffe2c4054","ref":"refs/heads/pg15","pushedAt":"2024-05-23T06:15:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"arpang","name":"Arpan Agrawal","path":"/arpang","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9985824?s=80&v=4"},"commit":{"message":"[pg15] test: fix some issues in TestYsqlUpgrade\n\nSummary:\nFix the following issues in TestYsqlUpgrade:\n- With PG commit 578b229718e8f15fa779e20f086c4b6bb3776106:\n - OID is a regular column.\n - WITH(OIDS = true) is no longer supported in CREATE TABLE.\n - Oid column is no longer automatically populated during inserts into a catalog table. Use `pg_nextoid()` for cases when explicit OID is not available during insertion.\n - pg_class.relhasoids field has been removed.\n\n- In test `creatingSharedRelsIsLikeInitdb`, update the schema of relation \"database_2\" to match the latest schema of pg_database.\n\n- Ignore tests that use recreateWithYsqlVersion() till pg15-based snapshot is available (it will be available towards the end of the project).\n\nTests creatingSharedRelsCreatesThemEverywhere and insertOnConflictWithOidsWorks pass with this change, add them to passing_test list. Remaining tests fail due to unrelated reasons.\n\nTest Plan:\nJenkins: rebase: pg15, test regex:TestYsqlUpgrade*\n\n ./pg15_tests/test_lint.sh\n for _ in {1..50}; do grep creatingSharedRelsCreatesThemEverywhere pg15_tests/passing_tests.tsv; done | pg15_tests/run_tests.sh\n for _ in {1..50}; do grep insertOnConflictWithOidsWorks pg15_tests/passing_tests.tsv; done | pg15_tests/run_tests.sh\n\nReviewers: jason, fizaa\n\nReviewed By: fizaa\n\nSubscribers: yql\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D35002","shortMessageHtmlLink":"[pg15] test: fix some issues in TestYsqlUpgrade"}},{"before":"e8b1ee49d60291eb2b423681e2d4d44f36fa35ac","after":"3797d41aaf063a4d74fc9ed5045d3afe268c7d1e","ref":"refs/heads/master","pushedAt":"2024-05-23T06:10:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"asharma-yb","name":"Ayush Sharma","path":"/asharma-yb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/109268085?s=80&v=4"},"commit":{"message":"[PLAT-13934]truncate the query returned in in pg_stat_statement responses\n\nSummary: limit the queries in slow queries response to 1024 characters\n\nTest Plan:\nExisting UTs.\nManually verified slow queries function as expected.\n\nReviewers: nbhatia, sanketh, dnolan\n\nReviewed By: nbhatia\n\nSubscribers: yugaware\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D35262","shortMessageHtmlLink":"[PLAT-13934]truncate the query returned in in pg_stat_statement respo…"}},{"before":"9ea96150b4be60847884ad7b81506200b23b8d6a","after":"f1f4a4709a5fa12d41553aece124bcc41d1551a1","ref":"refs/heads/pg15","pushedAt":"2024-05-23T05:32:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"arpang","name":"Arpan Agrawal","path":"/arpang","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9985824?s=80&v=4"},"commit":{"message":"[pg15] fix: rework YbGetMaxAllocatedSystemOid()\n\nSummary:\nPart 1:\n\nTo get the list of catalog relations that have OID columns, the function `YbGetMaxAllocatedSystemOid()` executed the below query:\n SELECT * FROM pg_class WHERE relnamespace = 'pg_catalog'::regnamespace AND relhasoids = true;\n\nWith PG commit 578b229718e8f15fa779e20f086c4b6bb3776106 (titled, \"Remove WITH OIDS support, change oid catalog column visibility.\"), OIDs are regular columns, and pg_class.relhasoids is no longer available. Hence, the above query is no longer valid.\n\nRework the above query as:\n sys_rel_oids = SELECT oid FROM pg_class WHERE relnamespace = 'pg_catalog'::regnamespace AND relkind = 'r';\n SELECT * FROM pg_attribute WHERE attrelid in AND attname = 'oid';\n\nIn addition to the relations that have oid column, this query also fetches the attribute number of these columns. This is required because `ObjectIdAttributeNumber` is no longer available.\n\nPart 2:\nTo get the max allocated oid, YB master branch executes the below query and takes a max:\n SELECT * FROM x WHERE oid >= 10000 AND oid < 16384\n\nWhen this is done on the pg15 branch, this inevitably returns a value >= FirstUnpinnedObjectId (unpinned objects are present in catalog and it is taking a max). This implies that the objects created by using auto-generated oid will be unpinned (see a49d081235997c67e8aab7a523b17e8d1cb93184). This behaviour is no worse than what is there in the master branch. On the master branch, without an explicit oid, \"pinned\" entry cannot be created in pg_depend anyway.\n\nDo a minor optimization by changing the query to `SELECT * FROM x WHERE oid >= FirstUnpinnedObjectId AND oid < 16384`.\n\nLastly, update the migration README. TestYsqlUpgrade#creatingSystemRelsAfterFailure passes with this change, add it to passing test list.\n\nTest Plan:\nJenkins: rebase: pg15\n ./pg15_tests/test_lint.sh\n for _ in {1..50}; do grep creatingSystemRelsAfterFailure pg15_tests/passing_tests.tsv; done | pg15_tests/run_tests.sh\n\nReviewers: jason, fizaa\n\nReviewed By: fizaa\n\nSubscribers: yql\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D34935","shortMessageHtmlLink":"[pg15] fix: rework YbGetMaxAllocatedSystemOid()"}},{"before":"55e08fec3a96b4814eb3651c19a31f230e32660c","after":"e8b1ee49d60291eb2b423681e2d4d44f36fa35ac","ref":"refs/heads/master","pushedAt":"2024-05-23T04:08:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"amitanandaiyer","name":"Amitanand Aiyer","path":"/amitanandaiyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32495790?s=80&v=4"},"commit":{"message":"[#22501] ASH: Fix ci build after #21985\n\nSummary:\ncf0c09b broke one of the CI builds.\n\nBroken build: GCC 12, debug AlmaLinux 9\nhttps://github.com/yugabyte/yugabyte-db/actions/runs/9185098435/job/25258478418\nJira: DB-11430, DB-10904\n\nTest Plan: Jenkins\n\nReviewers: asrivastava, arybochkin\n\nReviewed By: asrivastava\n\nSubscribers: ybase\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D35278","shortMessageHtmlLink":"[#22501] ASH: Fix ci build after #21985"}},{"before":"b2fb6108848bb71c29b20be71b387402cf289ce9","after":"55e08fec3a96b4814eb3651c19a31f230e32660c","ref":"refs/heads/master","pushedAt":"2024-05-23T04:04:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nkhogen","name":"Naorem Khogendro Singh","path":"/nkhogen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4497599?s=80&v=4"},"commit":{"message":"[PLAT-13844] Upgrade golang crypto to 0.17+\n\nSummary: Update crypto and net.\n\nTest Plan: build succeeded. itest should pass too.\n\nReviewers: cwang, nbhatia\n\nReviewed By: cwang\n\nSubscribers: yugaware\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D35273","shortMessageHtmlLink":"[PLAT-13844] Upgrade golang crypto to 0.17+"}},{"before":"f97e1a78cebacd294f542596c08307cf8fc02a1a","after":"9e5a3312d4aa43388deaa20b265a4832faf40e44","ref":"refs/heads/2.20","pushedAt":"2024-05-23T00:24:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"foucher","name":null,"path":"/foucher","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6496319?s=80&v=4"},"commit":{"message":"[BACKPORT 2.20][#22396] YSQL: Fix memory leaks in ybcFetchNextHeapTuple\n\nSummary:\nOriginal commit: 524eb502e8ee0586e31dde80161122011419d54e / D35067\nYBCStatus is a pointer. One of the things HandleYBStatus does is free YBCStatus if it isn't NULL. Commit 94c98b311af48df5e0d82c0467292b7e3128501c added logic which bypasses HandleYBStatus in some cases when the YBCStatus isn't NULL, but without freeing the YBCStatus in those cases. Fix the memory leaks in these code paths while simplifying the logic.\nJira: DB-11296\n\nTest Plan: Jenkins\n\nReviewers: dmitry\n\nReviewed By: dmitry\n\nSubscribers: yql\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D35252","shortMessageHtmlLink":"[BACKPORT 2.20][#22396] YSQL: Fix memory leaks in ybcFetchNextHeapTuple"}},{"before":"f5d0995fc71da0aab64c06c1ff166a1b82e98d0e","after":"b2fb6108848bb71c29b20be71b387402cf289ce9","ref":"refs/heads/master","pushedAt":"2024-05-23T00:04:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"amannijhawan","name":"Aman Nijhawan","path":"/amannijhawan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1563216?s=80&v=4"},"commit":{"message":"[PLAT-13891] YNP: Wiring up base unp to node agent scripts folder\n\nSummary:\nThis pull request mostly wires up the scafolding needed for unp to exist, we can invoke unp using node-agent-provison.sh in the scripts directory.\n\nThis PR also sets up some basic structure for node agent and packages unp with node-agent.\n\nTested it by running the basic node-agent-provision.sh in a local build.\n\nDetailed Design doc for UNP: https://docs.google.com/document/d/1emGXOG_M6yi3sWise9E66ka8vNpegSgG7cXCHx6Novc/edit\n\nTest Plan:\n```\n[centos@dev-server-anijhawan-4 scripts]$ ./node-agent-provision.sh\n[2024-05-16_00_13_15 common.sh:600 activate_pex] Using pex virtualenv python executable now.\nhello world! I am the main.py file in the unp directory.\nansible-vault==2.1.0\nsetuptools==69.5.1\nansible==2.9.27\nJinja2==3.1.4\nMarkupSafe==2.1.5\nPyYAML==6.0.1\ncryptography==42.0.7\ncffi==1.16.0\npycparser==2.22\ndistro==1.5.0\nmitogen==0.2.9\nsix==1.10.0\nansible-vault==2.1.0\nsetuptools==69.5.1\nansible==2.9.27\nJinja2==3.1.4\nMarkupSafe==2.1.5\nPyYAML==6.0.1\ncryptography==42.0.7\ncffi==1.16.0\npycparser==2.22\ndistro==1.5.0\nmitogen==0.2.9\nsix==1.10.0\n[centos@dev-server-anijhawan-4 scripts]$ pwd\n/home/centos/code/yugabyte-db/managed/node-agent/test_package/2.23.0.0-PRE_RELEASE/scripts\n```\n\nReviewers: nsingh, svarshney, nbhatia, sanketh\n\nReviewed By: nsingh, svarshney, nbhatia\n\nSubscribers: yugaware\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D35115","shortMessageHtmlLink":"[PLAT-13891] YNP: Wiring up base unp to node agent scripts folder"}},{"before":"9121e0db5b3b2fd295bea4618830616b84b0876f","after":"fb70537748eae257ec3e11d72b55e1a487fa5393","ref":"refs/heads/2024.1","pushedAt":"2024-05-22T23:47:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"foucher","name":null,"path":"/foucher","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6496319?s=80&v=4"},"commit":{"message":"[BACKPORT 2024.1][#22396] YSQL: Fix memory leaks in ybcFetchNextHeapTuple\n\nSummary:\nOriginal commit: 524eb502e8ee0586e31dde80161122011419d54e / D35067\nYBCStatus is a pointer. One of the things HandleYBStatus does is free YBCStatus if it isn't NULL. Commit 94c98b311af48df5e0d82c0467292b7e3128501c added logic which bypasses HandleYBStatus in some cases when the YBCStatus isn't NULL, but without freeing the YBCStatus in those cases. Fix the memory leaks in these code paths while simplifying the logic.\nJira: DB-11296\n\nTest Plan: Jenkins\n\nReviewers: dmitry\n\nReviewed By: dmitry\n\nSubscribers: yql\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D35250","shortMessageHtmlLink":"[BACKPORT 2024.1][#22396] YSQL: Fix memory leaks in ybcFetchNextHeapT…"}},{"before":"86a68836f903577356630ca735a90cca07d0a4d0","after":"f97e1a78cebacd294f542596c08307cf8fc02a1a","ref":"refs/heads/2.20","pushedAt":"2024-05-22T22:51:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"iSignal","name":"Sanketh I","path":"/iSignal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8207010?s=80&v=4"},"commit":{"message":"[BACKPORT 2.20] [PLAT-13220] Skip read write health checks for xcluster txn target clusters\n\nSummary:\nXcluster txn target clusters are readonly, so these checks are expected to fail. Will turn\nthem off for now. We can consider a read-only test in the future.\n\nOriginal diff: https://phorge.dev.yugabyte.com/D35154\n\nTest Plan: Tested on master, unit tests\n\nReviewers: hzare, cwang\n\nReviewed By: hzare\n\nSubscribers: yugaware\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D35214","shortMessageHtmlLink":"[BACKPORT 2.20] [PLAT-13220] Skip read write health checks for xclust…"}},{"before":"57518253f0b04cfaaa8ba226ffd3ac1e460fef56","after":"f5d0995fc71da0aab64c06c1ff166a1b82e98d0e","ref":"refs/heads/master","pushedAt":"2024-05-22T22:46:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"iSignal","name":"Sanketh I","path":"/iSignal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8207010?s=80&v=4"},"commit":{"message":"[PLAT-13220] Skip read write health checks for xcluster txn target clusters\n\nSummary:\nXcluster txn target clusters are readonly, so these checks are expected to fail. Will turn\nthem off for now. We can consider a read-only test in the future.\n\nTest Plan: Will test on a DR setup\n\nReviewers: hzare, cwang\n\nReviewed By: hzare\n\nSubscribers: yugaware\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D35154","shortMessageHtmlLink":"[PLAT-13220] Skip read write health checks for xcluster txn target cl…"}},{"before":"03bf111f95a0951bff25c083e585b81c28df38f3","after":"9ea96150b4be60847884ad7b81506200b23b8d6a","ref":"refs/heads/pg15","pushedAt":"2024-05-22T22:26:54.000Z","pushType":"push","commitsCount":187,"pusher":{"login":"jasonyb","name":null,"path":"/jasonyb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/93959687?s=80&v=4"},"commit":{"message":"[pg15] merge: master branch commit '9aca7099340a96442cf5a7678db9bbd9fdcf4825' into pg15\n\nSummary:\nMerge YB master commit 9aca7099340a96442cf5a7678db9bbd9fdcf4825 titled\n\n [#21872] YSQL: Add Bitmap Scan partition pruning test\n\nand committed 2024-04-23T08:25:30-07:00 into YB pg15.\n\nYB pg15 initial merge refers to\n55782d561e55ef972f2470a4ae887dd791bb4a97.\n\n- dependency.c:\n - includes: YB master 07db0b57cee0aee372a6820638fd07cb20c499a9 adds\n miscadmin.h include while YB pg15 initial merge moves tablegroup.h\n include to YB includes section. Take both.\n- pg_depend.c:\n - includes: (about the same)\n - tablegroupHasDependents: YB master\n 07db0b57cee0aee372a6820638fd07cb20c499a9 adds this function with\n heap_open/heap_close. Upstream PG changes these to\n table_open/table_close, so do so here.\n- pg_shdepend.c:\n - includes: YB pg15 initial merge incorrectly adds empty line in the\n middle of PG includes, so get rid of that. To make matters worse,\n YB master 07db0b57cee0aee372a6820638fd07cb20c499a9 moves miscadmin.h\n include from PG includes to YB includes, even though it is in fact a\n PG include. Resolve both mistakes.\n - function declarations: YB master\n 07db0b57cee0aee372a6820638fd07cb20c499a9 adds parameter refobjid\n (should have YB prefix) to storeObjectDescription. Upstream PG\n 8255c7a5eeba8f1a38b7a431c04909bde4f5e67d changes indentation. YB\n pg15 initial merge removes isSharedObjectPinned. Trivial merge.\n - shdepFindImplicitTablegroup: (same as pg_depend.c\n tablegroupHasDependents)\n - checkSharedDependencies: upstream PG\n af6550d34466b3093edda54a0cc5a6f220d321b7 defers calling\n storeObjectDescription until after collecting and sorting all\n objects. YB master 07db0b57cee0aee372a6820638fd07cb20c499a9 adds an\n argument to the storeObjectDescription calls. Apply to the new\n locations.\n - storeObjectDescription: upstream PG\n ebfe2dbd6b624e2a428e14b7ee9322cc096f63f7 changes \"tablespace of\" to\n \"tablespace for\". YB master\n 07db0b57cee0aee372a6820638fd07cb20c499a9 moves this code under an if\n condition.\n- yb_system_views.sql:\n - yb_local_tablets: before YB pg15 initial merge, only\n yb_system_views.sql is used, which contains copies of\n views/functions in system_views.sql in addition to YB-introduced\n views/functions; after, yb_system_views.sql contains only\n YB-introduced views/functions, and upstream\n system_views.sql/system_functions.sql are additionally used. YB\n master bf5fb1acd656c8f285d25ba1d77a42f7c6a4a5b1 adds a YB view, so\n leave it in yb_system_views.sql.\n- indexcmds.c:\n - DefineIndex: YB master 07db0b57cee0aee372a6820638fd07cb20c499a9\n touches some code that was indented under if (IsYugaByteEnabled())\n by YB pg15 0fcf6e4ed48581de3cec14a77fd7662fdb4fd2a7.\n- tablecmds.c:\n - function declarations: YB master\n 17bc7275828298ad81995bef4664a0e427690b3b changes \"List **handles\" to\n \"List *volatile *handles\". Adjacent lines conflict with surrounding\n changes such as indentation in YB pg15.\n- tablegroup.c:\n - RemoveTablegroupById: YB pg15 initial merge changes heap_open to\n table_open. Adjacent lines conflict with YB master\n 07db0b57cee0aee372a6820638fd07cb20c499a9 that adds code next to it.\n- nodeYbBitmapTablescan.c:\n - YbBitmapTableNext: YB master\n 03fd372291712fd341cf8ad89b3d01afceec5ee6 moves \"scandesc =\n node->ss.ss_currentScanDesc;\" line lower. This line and surrounding\n lines are slightly different in YB pg15. Move \"tsdesc =\n node->ss.ss_currentScanDesc;\" line lower.\n- gram.y:\n - stmt: YB master 9ac306a2cf2ff0ef0f0abab2d7c36c20c22295fe enables\n SecLabelStmt. YB pg15 initial merge moves ReindexStmt up (it was\n enabled in YB master b9fb4544e635746c0094e90f8f6fec61d3d091d3 but\n not moved up). Adjacent conflict.\n- postmaster.c:\n - BackendInitialize: YB master\n 6bd88e6eb34927b552dfab7df7d625ef0dcbe902 adds YBC_LOG_INFO call\n after init_ps_display. Upstream PG\n bf68b79e50e3359accc85c94fa23cc03abb9350a and\n 58c6feccfae1321ea4ff16c535c6f3fb90a07d69 change the surrounding code\n quite a bit. In particular, remote_ps_data local variable is\n removed, and the remote_host and remote_port are used manually to\n build the fixed_part passed to init_ps_display. Since YB master\n prints the remote_ps_data in the log, bring back the code to\n construct remote_ps_data under YB scope.\n- postgres.c:\n - yb_is_restart_possible:\n - signature: YB pg15 initial merge \"fixes\" indentation (it shouldn't\n have) which causes unnecessary conflicts with YB master\n b72433e4fa94324c62fbd2b3a9d4e3f0919c39e5 which removes those\n lines.\n - body:\n - YB pg15 initial merge adds \"CommandTag command_tag\" local\n variable to replace \"const char* command_tag\" in YB master to\n adapt to upstream PG 2f9661311b83dc481fc19f6e3bda015392010a40\n which changes the type of command_tag. YB pg15 initial merge\n also moves the variable declaration to the top of the file,\n adjacent-line conflicting with YB master\n b72433e4fa94324c62fbd2b3a9d4e3f0919c39e5 adding \"if\n (yb_debug_log_internal_restarts)\".\n - YB pg15 9c25c56116480fb43c3aaa8a19051a439b2964ac changes DEBUG1\n to DEBUG2 in a log that YB master\n b72433e4fa94324c62fbd2b3a9d4e3f0919c39e5 removes.\n- postgresql.conf.sample:\n - YB master d73ae39a48982024d0a8a9bbbe003a4d468c1eb3 adds\n yb_enable_parallel_append line. Adjacent line conflict with YB pg15\n initial merge which sets yb_enable_expression_pushdown line to off.\n- pg_proc.dat:\n - Adjacent line conflicts between YB master\n a1e2404c5b5757924edc653590a0625d5a271c42 and YB pg15 initial merge.\n- event_trigger.h:\n - YB_AT_REWRITE_ALTER_PRIMARY_KEY: adjacent lines conflict between\n upstream PG 578b229718e8f15fa779e20f086c4b6bb3776106 and\n b0483263dda0824cc49e3f8a022dab07e1cdf9a7 and YB master\n ddd6c8ce3c02a72b1e2cb12e64fd1f924595f9d9.\n- yb_bitmap_scans.out:\n - UPDATE tenk3 SET unique2 = NULL WHERE unique2 < 100 OR unique1 < 10:\n YB pg15 ad2fedc7be64eecd051846ac0ef7c6a6a229b5ef changes rows=10 to\n rows=0 for the explain cost estimate, but YB master\n 7b418b830b281267b0bde42367d423863f08c508 also does the same (plus\n more), so go with YB master.\n - DELETE FROM tenk3 WHERE unique2 IS NULL OR unique1 < 1000: (same)\n- yb_pg_misc_independent_serial_schedule:\n - YB pg15 946a8a95cc6d59eb168fbb26fa164e1581c35a3c adds yb_pg_lock\n test in the same place YB master\n 9ac306a2cf2ff0ef0f0abab2d7c36c20c22295fe adds yb_pg_security_label\n test. Take care to order the two tests correctly to pass lint.\n- pg_dml.cc:\n - PgDml::AppendTargetPB: YB master\n 03fd372291712fd341cf8ad89b3d01afceec5ee6 removes\n has_regular_targets_ logic, and YB pg15\n cd1df468c56a3ea7de0eecee1b0fc98c566cc86a brings back\n target->is_system() logic for that sake, so remove both.\n- pggate.cc:\n - PgApiImpl::DmlHasRegularTargets: (same)\n- pggate.h:\n - DmlHasRegularTargets: (same)\n- ybc_pggate.cc:\n - YBCPgDmlHasRegularTargets: (same)\n- ybc_pggate.h:\n - YBCPgDmlHasRegularTargets: (same)\n- pg_stat.c:\n - pgstat_get_wait_event_type: YB master\n 144891640161cd90caba630ec0c0cb3400ed80bd makes modifications to this\n function, but YB pg15 initial merge moves this function to\n wait_event.c in accordance with upstream PG 15.\n- wait_event.c:\n - pgstat_get_wait_event_type: accept changes from YB master\n 144891640161cd90caba630ec0c0cb3400ed80bd.\n- yb_scan.c:\n - YbBindRowComparisonKeys: similar to the resolution done in YB pg15\n 3a06b41e179fc58dc9d59e15eb66fc553bc985be yb_scan.c YbBindScanKeys.\n YB master 5595277d54c8048f40fdd2cdf6b5df48ced2fb5e adds\n \"ybScan->relation\". YB pg15 initial merge changes\n \"ybScan->relation\" to \"((TableScanDesc)ybScan)->rs_rd\", for example,\n in other places. Apply that change here.\n- yb_xcluster_ddl_replication.c:\n - HandleSourceDDLEnd: YB master\n 7b2565184dfabe57f6196e8cfda80a064acf3980 uses FunctionCallInfoData.\n Upstream PG a9c35cf85ca1ff72f16f0f10d7ddee6e582b62b8 changes the way\n it is used. Adapt accordingly.\n- pg15_tests/test_yb_bitmap_scans.sh:\n - After YB master 7b418b830b281267b0bde42367d423863f08c508, the\n differences in cost disappear, so no longer expect those.\n - Update diff line numbers.\n- yb_query_layer_retries_for_a_multi_statement_query.out:\n - YB master b72433e4fa94324c62fbd2b3a9d4e3f0919c39e5 introduces this\n test. Fix failures, which are merge related:\n - Upstream PG 741d7f1047fe52da7ced6fa9cea661ce9320c8d4 removes\n \"error in steps\" part of messages.\n - Upstream PG 4a054069a36032a59afceb07f3b837f09ab1a2e9 changes\n output format.\n These merge related differences are present in other tests as well,\n but leave fixing that for another day.\n- pg_hint_plan.out:\n - EXPLAIN (COSTS false) SELECT * FROM ischk WHERE b = 'x': somehow,\n this explain plan changed from using parallel workers to not. The\n change is closer to upstream pg_hint_plan, so no complaints here.\n- yb_colocated_tables_with_tablespaces.out:\n - This test is added by YB master\n 07db0b57cee0aee372a6820638fd07cb20c499a9. Change \"tablespace of\" to\n \"tablespace for\" (see pg_shdepend.c storeObjectDescription).\n- xcluster_ddl_replication-test.cc:\n - TEST_F(XClusterDDLReplicationTest, CreateTable): YB master\n 7b2565184dfabe57f6196e8cfda80a064acf3980 updates this test to do\n CREATE TABLEs as a new user. This causes \"permission denied\"\n failure due to upstream PG b073c3ccd06e4cb845e121387a43faa8c68a7b62.\n GRANT CREATE permissions on the public schema for this test. GRANT\n appears to require setting GUC\n yb_xcluster_ddl_replication.enable_manual_ddl_replication.\n\nTest Plan:\nOn Almalinux8, fastdebug, gcc11, pg15_tests/run_tests.sh should fail\nonly on tests with \"TestAlterOperationTableRewrite\" because those should\nbe renamed by D35179. Also, get the following results for these test\nplan tests:\n\n 0\t2024-05-17T16:58:41-07:00\tintegration-tests_xcluster_ddl_replication-test\tXClusterDDLReplicationTest.CreateTable\n 1\t2024-05-17T17:15:33-07:00\tJAVA\torg.yb.ysqlconnmgr.TestDropAndRenameDb\n 0\t2024-05-17T17:24:40-07:00\tJAVA\torg.yb.pgsql.TestPgRegressYbExtensionsYbXclusterDdlReplication\n 0\t2024-05-17T17:26:09-07:00\tintegration-tests_xcluster_ddl_replication-test\tXClusterDDLReplicationTest.CreateTable\n 0\t2024-05-17T17:26:40-07:00\tintegration-tests_xcluster_db_scoped-test\tXClusterDBScopedTest.DropTableOnProducerThenConsumer\n 1\t2024-05-17T17:27:55-07:00\tJAVA\torg.yb.pgsql.TestPgRegressTAQO#testPgRegressTAQO\n 1\t2024-05-17T17:29:13-07:00\tJAVA\torg.yb.pgsql.TestPgRegressParallel\n 1\t2024-05-17T17:29:37-07:00\tJAVA\torg.yb.pgsql.TestYsqlMetrics#testStatementStats\n 0\t2024-05-17T17:29:47-07:00\tintegration-tests_cdc_service-int-test\tCDCServiceTest.TestWALPrematureGCErrorCode\n 0\t2024-05-17T17:29:53-07:00\tmaster_load_balancer_mocked-test\tLoadBalancerMockedTest.TestPendingStepdown\n 0\t2024-05-17T17:29:58-07:00\tmaster_load_balancer_mocked-test\tLoadBalancerMockedTest.TestAddReplicaToTSWithPendingDelete\n 0\t2024-05-17T17:31:12-07:00\tintegration-tests_xcluster_ddl_replication-test\tXClusterDDLReplicationTest.ExactlyOnceReplication\n 1\t2024-05-17T17:32:03-07:00\tJAVA\torg.yb.pgsql.TestPgRegressRules#testPgRegressRules\n 0\t2024-05-17T17:32:40-07:00\tpgwrapper_colocation-test\tColocatedTablesWithTablespacesTest.ColocatedTablespaceTest\n 0\t2024-05-17T17:33:29-07:00\tpgwrapper_colocation-test\tColocatedTablesWithTablespacesTest.ColocatedIndexWithTablespaceTest\n 0\t2024-05-17T17:34:05-07:00\tpgwrapper_colocation-test\tColocatedTablesWithTablespacesTest.ColocatedPartitionedTableWithTablespaceTest\n 0\t2024-05-17T17:35:00-07:00\ttools_yb-backup-cross-feature-test\tYBBackupTestColocatedTablesWithTablespaces.TestBackupColocatedTablesWithTablespaces\n 0\t2024-05-17T17:35:54-07:00\ttools_yb-backup-cross-feature-test\tYBBackupTestColocatedTablesWithTablespaces.TestBackupColocatedTablesWithoutTablespaces\n 0\t2024-05-17T17:36:52-07:00\tJAVA\torg.yb.pgsql.TestPgRegressColocatedTablesWithTablespaces#testPgRegressColocatedTablesWithTablespaces\n 1\t2024-05-17T17:48:12-07:00\tJAVA\torg.yb.ysqlconnmgr.TestDropAndRenameDb\n 0\t2024-05-17T17:48:23-07:00\tmaster_master_xrepl-test\tMasterTestXRepl.TestYsqlBackfillReplicationSlotNameToCDCSDKStreamInvalidReplicaIdentity\n 0\t2024-05-17T17:48:33-07:00\tmaster_master_xrepl-test\tMasterTestXRepl.TestYsqlBackfillReplicationSlotNameToCDCSDKStream\n 1\t2024-05-17T17:49:56-07:00\tJAVA\torg.yb.pgsql.TestPgRegressMisc#testPgRegressMiscIndependent\n 0\t2024-05-17T17:51:33-07:00\tJAVA\torg.yb.pgsql.TestPgConfiguration\n 0\t2024-05-17T17:51:52-07:00\tpgwrapper_pg_wait_on_conflict-test\tPgWaitQueueRF1Test.TestDeadlockAcrossMultipleTablets\n 0\t2024-05-17T17:52:13-07:00\tpgwrapper_pg_wait_on_conflict-test\tPgWaitQueueRF1Test.TestDetectorPreservesBlockerSubtxnInfo\n 0\t2024-05-17T17:52:35-07:00\tintegration-tests_cdcsdk_ysql-test\tCDCSDKYsqlTest.TestPopulationOfDDLRecordUponCacheMiss\n 0\t2024-05-17T17:53:04-07:00\tpgwrapper_pg_catalog_version-test\tPgCatalogVersionTest.InvalidateWholeRelCache\n 0\t2024-05-17T17:53:17-07:00\tintegration-tests_xcluster-test\tXClusterTest.DeleteWithoutStreamCleanup\n 0\t2024-05-17T17:53:32-07:00\tintegration-tests_wait_states-itest\tWaitStateITest.AshPg\n 0\t2024-05-17T17:53:57-07:00\tpgwrapper_pg_get_lock_status-test\tPgGetLockStatusTest.TestPgLocksOutputAfterTableRewrite\n 1\t2024-05-17T17:58:29-07:00\tJAVA\torg.yb.pgsql.TestPgRegressPartitions#pruning\n\nAlso,\n\n ./yb_build.sh fastdebug --gcc11 --enable-ysql-conn-mgr-test --java-test 'org.yb.pgsql.TestYbPgStatActivity#testMemUsageOfQueryFromPgStatActivity'\t./yb_build.sh fastdebug --gcc11 --enable-ysql-conn-mgr-test --java-test 'org.yb.pgsql.TestYbPgStatActivity#testMemUsageOfQueryFromPgStatActivity'\t0\n ./yb_build.sh fastdebug --gcc11 --enable-ysql-conn-mgr-test --java-test 'org.yb.pgsql.TestPgConfiguration#testTimezoneFlag'\t./yb_build.sh fastdebug --gcc11 --enable-ysql-conn-mgr-test --java-test 'org.yb.pgsql.TestPgConfiguration#testTimezoneFlag'\t0\n #./yb_build.sh fastdebug --gcc11 --enable-ysql-conn-mgr-test --java-test 'org.yb.pgsql.TestPgAuthorization#testLongPasswords'\t#./yb_build.sh fastdebug --gcc11 --enable-ysql-conn-mgr-test --java-test 'org.yb.pgsql.TestPgAuthorization#testLongPasswords'\t0\n\nJenkins: rebase: pg15\n\nReviewers: aagrawal, fizaa, tfoucher\n\nReviewed By: tfoucher\n\nSubscribers: yql\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D35142","shortMessageHtmlLink":"[pg15] merge: master branch commit '9aca7099340a96442cf5a7678db9bbd9f…"}},{"before":"b19193d4a4c342de8b86f817ce7ed3ca504e24d0","after":"57518253f0b04cfaaa8ba226ffd3ac1e460fef56","ref":"refs/heads/master","pushedAt":"2024-05-22T22:23:42.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"andrei-mart","name":"Andrei Martsinchyk","path":"/andrei-mart","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1223507?s=80&v=4"},"commit":{"message":"[#21929] YSQL: Enhancing insert performance by retrieving values from a TupleTableSlot\n\nA TupleTableSlot parameter replaces HeapTuple and TupleDescriptor parameters in all DocDB insert procedures, including bulk insert. \r\n\r\nIn Postgres insert procedures work with a HeapTuple, because it represent on-disk format, so tuple data was simply copied into the data page. DocDB store individual values (Datums). In Yugabyte insert procedures operated on HeapTuple too, because it was ready available, however HeapTuple is less efficient to retrieve individual values, especially if tuple has variable length arguments. Fixed size arguments allow to calculate data offsets once, but since variable size value occur in the tuple, to retrieve a value from a HeapTuple it is necessary to iterate over all columns from the beginning and calculate offsets. \r\n\r\nThis impacted a lot extremely wide tables with hundreds of columns. Values were added to the DocDB statement, one by one, and each time columns were iterated to find the offset. Hundreds of columns required up to hundreds iterations each.\r\nWith new approach tuple may be already in slot and dematerialized at the time when it is about to be sent to DocDB for insert. If so, all values are readily available and materialization step is not needed. In worst case, if there is a HeapTuple to insert, access to values via TupleTableSlot does dematerialization in one pass, no multiple iterations over columns. \r\n\r\nEffect is barely noticeable for tables with a few/several columns, but load tests into tables with 1000+ columns show up to 3x improvement.","shortMessageHtmlLink":"[#21929] YSQL: Enhancing insert performance by retrieving values from…"}},{"before":"b5ca4d301616c6b6816bab0d7cfaaaad16ca0fd6","after":"a0e0fe2587e95998dce7eb46f76db74ec525fb5a","ref":"refs/heads/2.20.3","pushedAt":"2024-05-22T22:22:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"yifanguan","name":"Yifan Guan","path":"/yifanguan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/31666298?s=80&v=4"},"commit":{"message":"[BACKPORT 2.20.3][#22356] YSQL: make yb_get_range_split_clause robust using PG TRY CATCH block\n\nSummary:\n`yb_get_range_split_clause` is used by `ysql_dump` to generate YSQL table and index SPLIT AT VALUES clause for multi-tablet range-partitioned relation during backup.\nIt fails to decode `GinNull` in GIN Index partition bounds.\nWith the change in this diff, `yb_get_range_split_clause` checks for the existence of `GinNull` in partition bounds. If `GinNull` exists in partition bounds,\nan empty string is returned by `yb_get_range_split_clause`.\nAlso, there might be other unknown cases where partition bounds decoding can fail, which blocks YB backup.\nThus, protect the decoding in `yb_get_range_split_clause` with PG TRY CATCH block in case of decoding failure for the sake of YB backup.\nIf decoding fails, a warning is thrown and an empty string is returned by `yb_get_range_split_clause`.\nEach time `yb_get_range_split_clause` returns an empty string for a multi-tablet range relation, during restore, the relation is repartitioned with correct partition boundaries.\nJira: DB-11260\n\nOriginal commit: 7fbebe9d04ce91e9077b2efacfffc8ca99471384 / D34965\n\nTest Plan:\nJenkins: urgent\n./yb_build.sh --cxx-test yb-backup-cross-feature-test --gtest_filter YBBackupTest.TestYSQLTabletSplitGINIndexWithGinNullInPartitionBounds\n\nReviewers: mihnea, jason\n\nReviewed By: jason\n\nSubscribers: yql, ybase\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D35249","shortMessageHtmlLink":"[BACKPORT 2.20.3][#22356] YSQL: make yb_get_range_split_clause robust…"}},{"before":"71dd228aa4abf7969c7bad342289885b74b6ab09","after":"b19193d4a4c342de8b86f817ce7ed3ca504e24d0","ref":"refs/heads/master","pushedAt":"2024-05-22T19:55:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chidmuthu","name":"Muthu Chidambaram","path":"/chidmuthu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/86024920?s=80&v=4"},"commit":{"message":"[PLAT-13835][PLAT-13836] Upgrading python dependencies\n\nSummary: Upgrading setuptools and cyrptography. Running freeze altogether and landing in one diff.\n\nTest Plan: Ensure test suite still passes\n\nReviewers: svarshney, amalyshev, nsingh\n\nReviewed By: svarshney\n\nSubscribers: yugaware\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D35256","shortMessageHtmlLink":"[PLAT-13835][PLAT-13836] Upgrading python dependencies"}},{"before":"82cd5aafd874fc241cb4c5326e38dd65f05f11ac","after":"71dd228aa4abf7969c7bad342289885b74b6ab09","ref":"refs/heads/master","pushedAt":"2024-05-22T19:01:53.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"aishwarya24","name":"Aishwarya Chakravarthy ","path":"/aishwarya24","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5341399?s=80&v=4"},"commit":{"message":"[docs] made changes based on suggestions (#22493)","shortMessageHtmlLink":"[docs] made changes based on suggestions (#22493)"}},{"before":"92d99e0d2897ac98abcc8afce3c9af94d82ef971","after":"82cd5aafd874fc241cb4c5326e38dd65f05f11ac","ref":"refs/heads/master","pushedAt":"2024-05-22T17:38:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Vars-07","name":"Shubham Varshney","path":"/Vars-07","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19248012?s=80&v=4"},"commit":{"message":"[PLAT-13886] Adds support for running node exporter as user level systemd\n\nSummary:\nAdds support for running node exporter as user level systemd.\nWe will start running node_exporter as user level systemd - so that we can install this during the configure phase.\nThis will help simplify the onprem manual deployment as post this change we won't need the sudo user for installing the same.\n\nCorresponding change in ansible prometheus are as part of - https://github.com/yugabyte/ansible-prometheus/pull/12\n\nTest Plan:\nCreated alma based universe.\nVerified that the node_exporter is running as user level service.\nStarted the workload on the universe.\nVerified that the metrics are working as expected.\n\nCreated centos based universe.\nVerified that the node_exporter is running as system level service.\nStarted the workload on the universe.\nVerified that the metrics are working as expected.\n\nReviewers: amalyshev, anijhawan, sanketh\n\nReviewed By: amalyshev\n\nSubscribers: yugaware\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D35128","shortMessageHtmlLink":"[PLAT-13886] Adds support for running node exporter as user level sys…"}},{"before":"4d4ed695c102153fd6f473ae91b5b806291f697b","after":"92d99e0d2897ac98abcc8afce3c9af94d82ef971","ref":"refs/heads/master","pushedAt":"2024-05-22T17:00:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"amannijhawan","name":"Aman Nijhawan","path":"/amannijhawan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1563216?s=80&v=4"},"commit":{"message":"[PLAT-13889] UNP: Package Jinja2 with node agent\n\nSummary: Adding jinja2 to node agent pex environment to get unp dependancies to work.\n\nTest Plan:\n```\n(pexvenv) [centos@dev-server-anijhawan-4 pexvenv]$ python\nPython 3.8.16 (default, Apr 3 2023, 12:38:05)\n[GCC 8.5.0 20210514 (Red Hat 8.5.0-18)] on linux\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n\n>>> import jinja2\n>>> jinja2.__version__\n'3.0.3'\n```\n\nReviewers: nsingh, svarshney\n\nReviewed By: nsingh, svarshney\n\nSubscribers: yugaware\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D35111","shortMessageHtmlLink":"[PLAT-13889] UNP: Package Jinja2 with node agent"}},{"before":null,"after":"1036eb82f187ac6016d29320464cdb7706717fb6","ref":"refs/heads/2.21.1","pushedAt":"2024-05-22T16:56:27.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"svarnau","name":"Steve Varnau","path":"/svarnau","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5273190?s=80&v=4"},"commit":{"message":"Bumping version to 2.21.1.0 on branch 2.21.1","shortMessageHtmlLink":"Bumping version to 2.21.1.0 on branch 2.21.1"}},{"before":"f1d2e3e512c3f73056a0aeb0f32e018a10a4110e","after":"4380b7e4b37c1b422ec843a7f4372d0c68d5bbdc","ref":"refs/heads/2024.1.0","pushedAt":"2024-05-22T16:34:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"shubin-yb","name":"Daniel Shubin","path":"/shubin-yb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/117757925?s=80&v=4"},"commit":{"message":"[BACKPORT 2024.1.0][PLAT-14057] When querying releases with a deployment type, strip out artifacts that don't map to a release\n\nSummary:\nOriginal commit: None / D35241\nit is possible (though not a common workflow) that an artifact may not map to\na release (The release column would be null). When querying for all releases\nwith an artifact of a given \"type\", we need to be sure to not include artifacts\nthat do not map to a release, as ebean will through an NPE (psql query seems tohandle it implicitly, though the query\nformat is a bit different).\n\nTest Plan:\n1. removed artifacts with null release column. Fixed NPE on running YBAs\n2. tested fix with artifacts that have null release column, query works\n3. added UT\n\nReviewers: muthu, anijhawan\n\nReviewed By: muthu\n\nSubscribers: yugaware\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D35243","shortMessageHtmlLink":"[BACKPORT 2024.1.0][PLAT-14057] When querying releases with a deploym…"}},{"before":"b25bbdd1e2b8a56767a20b0673ffcf2facee38df","after":"9121e0db5b3b2fd295bea4618830616b84b0876f","ref":"refs/heads/2024.1","pushedAt":"2024-05-22T16:28:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"shubin-yb","name":"Daniel Shubin","path":"/shubin-yb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/117757925?s=80&v=4"},"commit":{"message":"[BACKPORT 2024.1][PLAT-14057] When querying releases with a deployment type, strip out artifacts that don't map to a release\n\nSummary:\nOriginal commit: None / D35241\nit is possible (though not a common workflow) that an artifact may not map to\na release (The release column would be null). When querying for all releases\nwith an artifact of a given \"type\", we need to be sure to not include artifacts\nthat do not map to a release, as ebean will through an NPE (psql query seems tohandle it implicitly, though the query\nformat is a bit different).\n\nTest Plan:\n1. removed artifacts with null release column. Fixed NPE on running YBAs\n2. tested fix with artifacts that have null release column, query works\n3. added UT\n\nReviewers: muthu, anijhawan\n\nReviewed By: muthu\n\nSubscribers: yugaware\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D35242","shortMessageHtmlLink":"[BACKPORT 2024.1][PLAT-14057] When querying releases with a deploymen…"}},{"before":"e06f49ffcc1fbb45212b9c241842ff742b563d47","after":"4d4ed695c102153fd6f473ae91b5b806291f697b","ref":"refs/heads/master","pushedAt":"2024-05-22T16:28:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"shubin-yb","name":"Daniel Shubin","path":"/shubin-yb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/117757925?s=80&v=4"},"commit":{"message":"[PLAT-14057] When querying releases with a deployment type, strip out artifacts that don't map to a release\n\nSummary:\nit is possible (though not a common workflow) that an artifact may not map to\na release (The release column would be null). When querying for all releases\nwith an artifact of a given \"type\", we need to be sure to not include artifacts\nthat do not map to a release, as ebean will through an NPE (psql query seems tohandle it implicitly, though the query\nformat is a bit different).\n\nTest Plan:\n1. removed artifacts with null release column. Fixed NPE on running YBAs\n2. tested fix with artifacts that have null release column, query works\n3. added UT\n\nReviewers: muthu, anijhawan\n\nReviewed By: muthu\n\nSubscribers: yugaware\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D35241","shortMessageHtmlLink":"[PLAT-14057] When querying releases with a deployment type, strip out…"}},{"before":"f6c29fd7058e5ff116e30efa64bdc680b5b1643b","after":"e06f49ffcc1fbb45212b9c241842ff742b563d47","ref":"refs/heads/master","pushedAt":"2024-05-22T16:00:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"SrivastavaAnubhav","name":"Anubhav Srivastava","path":"/SrivastavaAnubhav","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17299377?s=80&v=4"},"commit":{"message":"[#21269] docdb: Fix not being able to restore a snapshot schedule from oldest snapshot\n\nSummary:\nPrior to this diff, we incorrectly blocked restores to the time just before the oldest\nsnapshot in a snapshot schedule once all deleted snapshots are removed from an in-memory map. This\nis because we checked that the restore time is after oldest snapshot's hybrid time, but all\nsnapshots except the first one taken after creating the schedule have history since the previous\nsnapshot.\n\nCode to clean up snapshots for schedules already correctly calculates the earliest possible restore\ntime for a snapshot. This diff moves that calculation to a common function, `ComputeMinRestoreTime`,\nand calls it from the `RestoreSnapshotSchedule` code path.\n\nThis also enables cloning to a time just before the oldest snapshot.\n\nFixes #21269\nJira: DB-10187\n\nTest Plan: `./yb_build.sh --cxx_test clone_namespace-test --gtest_filter=CloneNamespaceTest.CloneFromOldestSnapshot`\n\nReviewers: zdrudi, mhaddad\n\nReviewed By: zdrudi\n\nSubscribers: yql, ybase\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D35120","shortMessageHtmlLink":"[#21269] docdb: Fix not being able to restore a snapshot schedule fro…"}},{"before":"c3be1a7d54d0df99cce898a379e6c775fed37505","after":"f6c29fd7058e5ff116e30efa64bdc680b5b1643b","ref":"refs/heads/master","pushedAt":"2024-05-22T15:24:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"OlegLoginov","name":"Oleg","path":"/OlegLoginov","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/31254529?s=80&v=4"},"commit":{"message":"[#21689] YBC Tests: Update MiniCluster to support YBC\n\nSummary:\nIn the `MiniCluster` test framework the following g-flags were added for usage in `YB Controller`.\n- `fs_data_dirs`\n- `tserver_master_addrs`\n- `pgsql_proxy_bind_address`\n- `cql_proxy_bind_address`\nThe flags are available via `/varz` HTTP API.\n\nFixed timeouts in `TestBackupWithoutTSWebUI` & `TestBackupRestoreWithoutTSWebUI` tests because `YBC` has internal timeout == 1 second.\n\nUse the `YB_DISABLE_MINICLUSTER_BACKUP_TESTS` environment variable for 2 not fixed tests only.\nJira: DB-10573\n\nTest Plan:\n# ExternalMiniCluster backup test example\n./yb_build.sh --cxx-test tools_yb-backup-cross-feature-test --gtest_filter YBBackupTest.TestPreSplitYSQLRangeSplitTableAndIndex\n\n# All MiniCluster YCQL backup tests:\n./yb_build.sh --cxx-test integration-tests_cql-backup-test --gtest_filter CqlBackupTest.TestBackupWithoutTSWebUI\n./yb_build.sh --cxx-test integration-tests_cql-backup-test --gtest_filter CqlBackupTest.TestBackupRestoreWithoutTSWebUI\n\n./yb_build.sh --cxx-test integration-tests_cql-backup-test --gtest_filter CqlBackupTest.TestRestoreUDT\n./yb_build.sh --cxx-test integration-tests_cql-backup-test --gtest_filter CqlBackupTest.TestRestoreReuseExistingUDT\n./yb_build.sh --cxx-test integration-tests_cql-backup-test --gtest_filter CqlBackupTest.TestRestoreUDTIntoNewKS\n./yb_build.sh --cxx-test integration-tests_cql-backup-test --gtest_filter CqlBackupTest.TestFailedImportSnapshot\n./yb_build.sh --cxx-test integration-tests_cql-backup-test --gtest_filter CqlBackupTest.TestFailedImportSnapshotKeepExistingUDT\n./yb_build.sh --cxx-test integration-tests_cql-backup-test --gtest_filter CqlBackupTest.TestFailedImportSnapshotKeepExistingKS\n\n# All MiniCluster YSQL backup tests:\n./yb_build.sh --cxx-test pgwrapper_pg_master_failover-test --gtest_filter PgMasterFailoverTest.NonRespondingMaster\n./yb_build.sh --cxx-test pgwrapper_pg_master_failover-test --gtest_filter PgMasterFailoverTest.NonRespondingMasterWithTSWaiting\n\nReviewers: mihnea, asharma\n\nReviewed By: asharma\n\nSubscribers: ybase, yql\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D34975","shortMessageHtmlLink":"[#21689] YBC Tests: Update MiniCluster to support YBC"}},{"before":"c51df5417fd85e7d605e7274b1c2280bb1cde0f1","after":"b25bbdd1e2b8a56767a20b0673ffcf2facee38df","ref":"refs/heads/2024.1","pushedAt":"2024-05-22T13:43:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Vars-07","name":"Shubham Varshney","path":"/Vars-07","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19248012?s=80&v=4"},"commit":{"message":"[BACKPORT 2024.1][PLAT-13755] Change the /tmp for metric to yb_home\n\nSummary: Previously we used to collect the node_metrics inside the `/tmp` directory. We should do this instead inside the yb home directory.\n\nTest Plan:\nManually tested the metrics & alerts are thrown\nShouldn't impact the existing deployments - we will move this for the newer deployments.\n\nDepends on - D34660\nOriginal Commit - https://github.com/yugabyte/yugabyte-db/commit/e4b4b25302b7053171fcd7bf123a94e8361def18\n\nReviewers: amalyshev\n\nReviewed By: amalyshev\n\nSubscribers: yugaware\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D35121","shortMessageHtmlLink":"[BACKPORT 2024.1][PLAT-13755] Change the /tmp for metric to yb_home"}},{"before":"10a89b52e3065a047e6875bf77207be0dc36e9f0","after":"86a68836f903577356630ca735a90cca07d0a4d0","ref":"refs/heads/2.20","pushedAt":"2024-05-22T13:42:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Vars-07","name":"Shubham Varshney","path":"/Vars-07","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19248012?s=80&v=4"},"commit":{"message":"[BACKPORT 2.20][PLAT-13755] Change the /tmp for metric to yb_home\n\nSummary: Previously we used to collect the node_metrics inside the `/tmp` directory. We should do this instead inside the yb home directory.\n\nTest Plan:\nManually tested the metrics & alerts are thrown\nShouldn't impact the existing deployments - we will move this for the newer deployments.\n\nDepends on - D34660\nOriginal Commit - https://github.com/yugabyte/yugabyte-db/commit/e4b4b25302b7053171fcd7bf123a94e8361def18\n\nReviewers: amalyshev\n\nReviewed By: amalyshev\n\nSubscribers: yugaware\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D35122","shortMessageHtmlLink":"[BACKPORT 2.20][PLAT-13755] Change the /tmp for metric to yb_home"}},{"before":"942e515cdf8847cbe3cb1606a3287d732833b9d4","after":null,"ref":"refs/heads/arcpatch-D33508","pushedAt":"2024-05-22T13:41:23.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Vars-07","name":"Shubham Varshney","path":"/Vars-07","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19248012?s=80&v=4"}},{"before":"50c56edd261ac2a82f906118af90747a6b3f99c5","after":"c51df5417fd85e7d605e7274b1c2280bb1cde0f1","ref":"refs/heads/2024.1","pushedAt":"2024-05-22T13:40:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Vars-07","name":"Shubham Varshney","path":"/Vars-07","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19248012?s=80&v=4"},"commit":{"message":"[BACKPORT 2024.1][PLAT-13907] Allow editing of in-use bundles based on runtime flag\n\nSummary:\nFiserv requires an ability to edit the image bundle name along with the backing AMI IDs for the image bundle even when the image\nbundle is associated with a universe. Adds support for editing image bundles under a runtime config.\nThey have in-house automation that performs the OS patching automatically, but given that YBA metadata is stale they needed the capability to modify the AMI details in YBA so that they can easily perform edit operations.\n\nConfig Name - `yb.edit_provider.new.allow_used_bundle_edit`\n\nDepends on - D34938\nOriginal Commit - https://github.com/yugabyte/yugabyte-db/commit/339ce2f10a40d4f99be484dff321d73942d15a47\n\nTest Plan:\nCreated a provider with custom bundle & deployed universe.\nTried editing the bundle - Verified it fails.\n\nSet the runtime flag.\nTried editing AMI in the bundle - Verified that the bundle is edited.\nVerified the same using imageBundle individual API as well.\n\nReviewers: #yba-api-review!, amalyshev\n\nReviewed By: amalyshev\n\nSubscribers: yugaware\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D35092","shortMessageHtmlLink":"[BACKPORT 2024.1][PLAT-13907] Allow editing of in-use bundles based o…"}},{"before":"a754591620f99f9f26d370a16a9b1628b3547f52","after":"10a89b52e3065a047e6875bf77207be0dc36e9f0","ref":"refs/heads/2.20","pushedAt":"2024-05-22T13:39:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Vars-07","name":"Shubham Varshney","path":"/Vars-07","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19248012?s=80&v=4"},"commit":{"message":"[BACKPORT 2.20][PLAT-13907] Allow editing of in-use bundles based on runtime flag\n\nSummary:\nFiserv requires an ability to edit the image bundle name along with the backing AMI IDs for the image bundle even when the image\nbundle is associated with a universe. Adds support for editing image bundles under a runtime config.\nThey have in-house automation that performs the OS patching automatically, but given that YBA metadata is stale they needed the capability to modify the AMI details in YBA so that they can easily perform edit operations.\n\nConfig Name - `yb.edit_provider.new.allow_used_bundle_edit`\n\nDepends on - D34938\nOriginal Commit - https://github.com/yugabyte/yugabyte-db/commit/339ce2f10a40d4f99be484dff321d73942d15a47\n\nTest Plan:\nCreated a provider with custom bundle & deployed universe.\nTried editing the bundle - Verified it fails.\n\nSet the runtime flag.\nTried editing AMI in the bundle - Verified that the bundle is edited.\nVerified the same using imageBundle individual API as well.\n\nReviewers: #yba-api-review!, amalyshev\n\nReviewed By: amalyshev\n\nSubscribers: yugaware\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D35093","shortMessageHtmlLink":"[BACKPORT 2.20][PLAT-13907] Allow editing of in-use bundles based on …"}},{"before":"6e6cb2ae1285460056eab1769dea6344561c8b7e","after":"c3be1a7d54d0df99cce898a379e6c775fed37505","ref":"refs/heads/master","pushedAt":"2024-05-22T13:37:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Vars-07","name":"Shubham Varshney","path":"/Vars-07","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19248012?s=80&v=4"},"commit":{"message":"[PLAT-13252] Changes for improving local Provider flakiness\n\nSummary:\nThis diff introduces several changes to the local Provider for tackling the flakiness.\nSome of which includes -\n 1. Creating a dedicated /tmp directory for each node.\n 2. Separate nfs backup directory for backup tests.\n 3. Killing postmaster processes as well post test completion\n\nTest Plan: itest-pipeline\n\nReviewers: sanketh, yshchetinin\n\nReviewed By: yshchetinin\n\nSubscribers: yugaware\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D35181","shortMessageHtmlLink":"[PLAT-13252] Changes for improving local Provider flakiness"}},{"before":"f72bf2cd49423d80ce9a5cd27856c77c0ef6519b","after":"50c56edd261ac2a82f906118af90747a6b3f99c5","ref":"refs/heads/2024.1","pushedAt":"2024-05-22T13:08:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Sumukh-Phalgaonkar","name":null,"path":"/Sumukh-Phalgaonkar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/61342752?s=80&v=4"},"commit":{"message":"[BACKPORT 2024.1][#22408] CDCSDK: Handle race condition in dynamic table creation.\n\nSummary:\nOriginal commit: 6e6cb2ae1285460056eab1769dea6344561c8b7e / D35160\nThere is a possible race condition when during dynamic table creation, the tablet creation is not completed i.e the retention barriers have not yet been set, but the background thread proceeds and adds the table to the stream. In such a case till the time the tablet creation succeeds, the retention barriers are not set on the tablets of this table, even though it has been added to the stream.\n\nThis was observed as flakiness in the test `TestRetentionBarrierRaceWithUpdatePeersAndMetrics` .\n\nThis diff introduces a fix for this race condition by calling GetTableLocations on the table before adding it to the stream. If the tablets are not yet initialized then this will fail and the addition of the table to the stream will take place in the next round of the background task.\n\n######Backport Description\nNo merge conflicts were encountered.\n\nJira: DB-11311\n\nTest Plan: Jenkins: test regex: .*CDCSDKConsumptionConsistentChangesTest.*\n\nReviewers: asrinivasan, stiwary, skumar\n\nReviewed By: asrinivasan\n\nSubscribers: ycdcxcluster, ybase\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D35263","shortMessageHtmlLink":"[BACKPORT 2024.1][#22408] CDCSDK: Handle race condition in dynamic ta…"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEUacrogA","startCursor":null,"endCursor":null}},"title":"Activity · yugabyte/yugabyte-db"}