Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve embedding of resources guideline. #483

Open
tkrop opened this issue Jan 24, 2019 · 7 comments
Open

Improve embedding of resources guideline. #483

tkrop opened this issue Jan 24, 2019 · 7 comments

Comments

@tkrop
Copy link
Member

tkrop commented Jan 24, 2019

Our HAL-based rule Should: Allow Optional Embedding of Sub-Resources predates our new Must: Use Common Hypertext Controls guideline and may not fit perfectly in this new world.

I'm wondering whether the we could find a better guidance here.

@ePaul
Copy link
Member

ePaul commented Mar 12, 2019

@tkrop will talk to @meshcalero about this.

@ePaul ePaul closed this as completed Mar 12, 2019
@ePaul ePaul reopened this Mar 12, 2019
@ePaul ePaul assigned meshcalero and unassigned tkrop Aug 27, 2019
@ePaul
Copy link
Member

ePaul commented Aug 27, 2019

@meshcalero will try to do a minimally-invasive PR for this.

@tfrauenstein
Copy link
Member

@meshcalero Hi Andreas, you recently said that you 'try to do a minimally-invasive PR for this' which would be great. Do you still have it on your to-do list? Thx.

@ePaul ePaul self-assigned this Feb 11, 2020
@ePaul
Copy link
Member

ePaul commented Feb 11, 2020

Idea: remove the _embedded field, instead use the embed parameter to expand a "common hypertext control" to a full object.

I'll try to figure out how to write this in a rule.

@whiskeysierra
Copy link
Contributor

Isn't _embedded part of the response while the embed parameter is part of the request? How should one substitute one with the other?

@ePaul
Copy link
Member

ePaul commented Feb 23, 2021

example API using this (internal link).

@ePaul
Copy link
Member

ePaul commented Jan 23, 2024

Reminder to me: Please finally do it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants