Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown (Vale) #548

Closed
1 task done
koozz opened this issue Apr 15, 2024 · 2 comments · Fixed by #691
Closed
1 task done

Markdown (Vale) #548

koozz opened this issue Apr 15, 2024 · 2 comments · Fixed by #691
Labels
language A request to add a language extension

Comments

@koozz
Copy link
Contributor

koozz commented Apr 15, 2024

Check for existing issues

  • Completed

Language

Markdown

Tree Sitter parser link

No response

Language server link

https://github.com/errata-ai/vale-ls

Misc notes

Markdown is supported in Zed, but Vale brings spellchecking and style checking to your markdown through a language server (which is written in Rust).

Vale compiles into a fast, dependency-free binary for macOS, Windows, and Linux.
Extensible
Vale helps you maintain a consistent and on-brand voice by allowing you to create your own custom rules.
Vale runs entirely offline—ensuring that your content is never sent to a remote server for processing.

Source: https://vale.sh/
@koozz koozz added the language A request to add a language extension label Apr 15, 2024
@koozz
Copy link
Contributor Author

koozz commented Apr 25, 2024

First attempt couldn't compile because the vale-ls is using Tokio, which doesn't compile to WASM.

Second attempt worked for a split second, I had the LSP error visible in Zed in my Markdown file, but after removing the Dev Extension and trying a clean Install Dev Extension the logs state:

2024-04-25T16:05:47+02:00 [INFO] compiling Rust extension /Users/jan/git/github.com/koozz/zed-vale
2024-04-25T16:05:47+02:00 [ERROR] crates/extensions_ui/src/extensions_ui.rs:66: failed to compile Rust extension

Caused by:
    0: failed to run rustc
    1: No such file or directory (os error 2)

I can successfully run cargo build --target=wasm32-wasi and also successfully execute ~/Library/Application\ Support/Zed/extensions/work/vale/vale-ls-v0.3.7/vale-ls.
Also removing ~/Library/Application\ Support/Zed/extensions/work/vale didn't help.

Any idea why it doesn't want to compile from Zed anymore?
Code is stored on koozz/zed-vale.

@koozz
Copy link
Contributor Author

koozz commented May 6, 2024

It seems to compile, but after a single working check, the language server seems to crash.

@koozz koozz mentioned this issue May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
language A request to add a language extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Vale extension for style and spellchecking koozz/zed-extensions
1 participant
@koozz