Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrolling on X11 snapping when window was out of focus #11206

Closed
1 task done
DissolveDZ opened this issue Apr 30, 2024 · 0 comments · Fixed by #11235
Closed
1 task done

Scrolling on X11 snapping when window was out of focus #11206

DissolveDZ opened this issue Apr 30, 2024 · 0 comments · Fixed by #11235
Labels
defect [core label] linux mouse interaction Feedback for mouse interaction states, actions, etc workspace Feedback for workspace management, layout, interactions, etc

Comments

@DissolveDZ
Copy link
Contributor

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Due to a recent commit (ec95605).
Scrolling on X11 feels the same but when exiting and re-entering Zed and scrolling it will snap way more than was scrolled. This is really annoying and I hope it gets fixed soon. I did some testing and it only happens after this commit.

Environment

Zed: v1.0.0 (Zed Dev f96cab2)
OS: Linux 1.0.0
Memory: 23.4 GiB
Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response
@DissolveDZ DissolveDZ added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Apr 30, 2024
@JosephTLyons JosephTLyons added mouse interaction Feedback for mouse interaction states, actions, etc workspace Feedback for workspace management, layout, interactions, etc linux and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Apr 30, 2024
@someone13574 someone13574 mentioned this issue May 1, 2024
Merged
@github-actions github-actions bot mentioned this issue May 1, 2024
Open
mikayla-maki added a commit that referenced this issue May 6, 2024
@someone13574 @mikayla-maki
Replace all X11 mouse events with XI2 equivalents (#11235)
9a60c0a 
This PR replaces all pointer events on X11 with their XI2 equivalents,
which fixes problems with scroll events not being reported when a mouse
button is down. Additionally it closes #11206 by resetting the tracked
global scroll valulator position with `None` on a leave event to prevent
a large scroll delta if scrolling is done outside the window. Lastly, it
resolves the bad window issue kvark was having.

Release Notes:

- Fixed X11 Scroll snapping (#11206 ).

---------

Co-authored-by: Mikayla Maki <mikayla@zed.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect [core label] linux mouse interaction Feedback for mouse interaction states, actions, etc workspace Feedback for workspace management, layout, interactions, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace all X11 mouse events with XI2 equivalents someone13574/zed
2 participants
@JosephTLyons @DissolveDZ