-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lines greater than 1024 chars long crash the editor on Windows 11. #11518
Comments
i can confirm that this issue also occurs for me on the latest commit: 6a64b73. |
It seems to break (but not crash) on Linux as well. You can not scroll past 1024 horizontally and if you insert anything it simply goes off the visible area. |
Found the problem. I used git bisect to find that #11080 (this commit specifically) changes the behavior of the soft-wrap mode "none" to not wrap for very long lines, which doesn't respect This long line wrapping seems like it was added for this exact reason (fixing clipping) in #866 which was a response to #834 |
So, I see two problems with Windows impl:
I would not want to deal with Windows anyhow special on this regard, IMO it's supposed to work with the long lines too disregarding of the wrapping mode. |
This surprised me. I tested it, and when calling |
#11536 should fix this, I tested it on my laptop. |
Stops lines from clipping at 1024 by default, returning it to the old default behaviour where it wraps at 512. The `none` mode is only supposed to be used for git hunks. See #11518 (comment). Release Notes: - N/A
Close #11518 Release Notes: - N/A
) Stops lines from clipping at 1024 by default, returning it to the old default behaviour where it wraps at 512. The `none` mode is only supposed to be used for git hunks. See zed-industries#11518 (comment). Release Notes: - N/A
…ndustries#11536) Close zed-industries#11518 Release Notes: - N/A
Check for existing issues
Describe the bug / provide steps to reproduce it
Lines greater than 1024 characters break windows. Steps to reproduce:
Here's the file I used: test.txt
Environment
Zed: v0.135.0 (Zed Dev d64106e)
OS: Windows 10.0.22631
Memory: 31.7 GiB
Architecture: x86_64
If applicable, attach your
~/Library/Logs/Zed/Zed.log
file to this issue.Zed.log
The text was updated successfully, but these errors were encountered: