Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in rx node retention mechanism in refactored LLCP, possibly leading to erroneous rx node handling #72845

Open
erbr-ot opened this issue May 16, 2024 · 2 comments
Assignees
Labels
area: Bluetooth Controller area: Bluetooth LLCP area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug

Comments

@erbr-ot
Copy link
Collaborator

erbr-ot commented May 16, 2024

Describe the bug
Two rx node specific errors were identified in the refactored LLCP implementation. Related to the rx node retention mechanism.

  1. In case a remote CPR is initiated while one is ongoing on other connection this would under specific circumstances lead to an rx node being retained, but not released.
  2. In case of a remote channel map update procedure the rx node reference gets stored but not cleared again, which will lead to possible error on the completion (at instant) - IF the rx node referenced has since been re-allocated for use in another procedure on other connection AND this has then been marked for retention, THEN the completion of channel map update, would see a non-released, retained rx node and then mark it for release. Possibly resulting in an assertion in the parallel procedure.

To Reproduce
Build any bluetooth sample and the above mentioned problems will be present.

Impact
The result of these issues is that during execution of LLCP, rx nodes could leak or be improperly released/modified. Consequently resulting in an assertion and/or 'un-explainable' rx node corruption.

Environment
Has been present since merge of #55921

@erbr-ot erbr-ot added the bug The issue is a bug, or the PR is fixing a bug label May 16, 2024
@erbr-ot
Copy link
Collaborator Author

erbr-ot commented May 16, 2024

fixed by: #71934

@henrikbrixandersen
Copy link
Member

Please use our bug template when reporting bugs. You need to edit this issue to include the information requested in https://github.com/zephyrproject-rtos/zephyr/blob/main/.github/ISSUE_TEMPLATE/001_bug_report.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth Controller area: Bluetooth LLCP area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Development

No branches or pull requests

4 participants