Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gateway NewRequestParser json.NewDecoder map result in loss of numerical precision #4067

Open
JiekeW opened this issue Apr 11, 2024 · 0 comments
Assignees
Labels
area/gateway Categorizes issue or PR as related to gateway.

Comments

@JiekeW
Copy link

JiekeW commented Apr 11, 2024

Describe the bug
Gateway NewRequestParser json.NewDecoder map result in loss of numerical precision

  1. The code is
// NewRequestParser creates a new request parser from the given http.Request and resolver.
func NewRequestParser(r *http.Request, resolver jsonpb.AnyResolver) (grpcurl.RequestParser, error) {
	vars := pathvar.Vars(r)
	params, err := httpx.GetFormValues(r)
	if err != nil {
		return nil, err
	}

	for k, v := range vars {
		params[k] = v
	}

	body, ok := getBody(r)
	if !ok {
		return buildJsonRequestParser(params, resolver)
	}

	if len(params) == 0 {
		return grpcurl.NewJSONRequestParser(body, resolver), nil
	}

	m := make(map[string]any)
	if err := json.NewDecoder(body).Decode(&m); err != nil && err != io.EOF {
		return nil, err
	}
	for k, v := range params {
		m[k] = v
	}
	return buildJsonRequestParser(m, resolver)
}
  1. The error is
    1975103407695073280 -> 1975103407695073300

  2. My solution is

// NewRequestParser creates a new request parser from the given http.Request and resolver.
func NewRequestParser(r *http.Request, resolver jsonpb.AnyResolver) (grpcurl.RequestParser, error) {
	vars := pathvar.Vars(r)
	params, err := httpx.GetFormValues(r)
	if err != nil {
		return nil, err
	}

	for k, v := range vars {
		params[k] = v
	}

	body, ok := getBody(r)
	if !ok {
		return buildJsonRequestParser(params, resolver)
	}

	if len(params) == 0 {
		return grpcurl.NewJSONRequestParser(body, resolver), nil
	}

	m := make(map[string]any)
	decoder := json.NewDecoder(body)
	decoder.UseNumber()
	if err := decoder.Decode(&m); err != nil && err != io.EOF {
		return nil, err
	}
	for k, v := range params {
		m[k] = v
	}
	return buildJsonRequestParser(m, resolver)
}
@kevwan kevwan self-assigned this Apr 13, 2024
@kevwan kevwan added the area/gateway Categorizes issue or PR as related to gateway. label Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway Categorizes issue or PR as related to gateway.
Projects
None yet
Development

No branches or pull requests

2 participants