Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to whether to generate pb file #4078

Open
wuqinqiang opened this issue Apr 16, 2024 · 1 comment
Open

Add a flag to whether to generate pb file #4078

wuqinqiang opened this issue Apr 16, 2024 · 1 comment

Comments

@wuqinqiang
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently, PB files do not support external imports, which makes it inconvenient to directly apply certain plugins as they require additional processing. For instance, basic plugins like protoc-gen-validate can not be used directly.

The ProtocCmd assembled by the GenPb function within goctl is somewhat insufficient. For my purposes, I only want to generate the framework's core code. As for managing and generating pb files, I prefer using buf.

demo

Therefore, I'd like to add a flag that allows skipping the generation of GenPb and only generates the core framework code.

Describe the solution you'd like
Add a flag: --pb

# skip generate GenPb 
goctl rpc protoc proto/demo2.proto --pb=false  ...........

Describe alternatives you've considered

Additional context

@wuqinqiang
Copy link
Contributor Author

@kevwan Will this be open -_-?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant