Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests folder is not included in the pugixml-1.10.zip #326

Open
Andreas-Schniertshauer opened this issue Jan 28, 2020 · 2 comments
Open

tests folder is not included in the pugixml-1.10.zip #326

Andreas-Schniertshauer opened this issue Jan 28, 2020 · 2 comments
Labels

Comments

@Andreas-Schniertshauer
Copy link

and when building with cmake -D BUILD_TESTS:BOOL=ON you get the following error
CMake Error at CMakeLists.txt:103 (list): list sub-command REMOVE_ITEM requires two or more arguments.

@zeux
Copy link
Owner

zeux commented Jan 29, 2020

So this is somewhat intentional - the release archive is built for the most common use which includes compiling code and reading documentation but not building tests or fuzzing.

However this was done before CMake and it is a bit odd to include a CMake file with broken options. I wonder if it makes more sense to include tests or to generate a better error message in CMake instead.

@zeux zeux added the build label Jan 29, 2020
@Andreas-Schniertshauer
Copy link
Author

I would prefer to include the test, so the user is able to verify that all is fine after compiling, e.g. Google Test and other libraries do this too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants