Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake find_package needs to be tested in CI #392

Open
zeux opened this issue Dec 18, 2020 · 1 comment
Open

CMake find_package needs to be tested in CI #392

zeux opened this issue Dec 18, 2020 · 1 comment

Comments

@zeux
Copy link
Owner

zeux commented Dec 18, 2020

v1.11 required three patches to introduce an alias for renamed pugixml::pugixml target; the alias was present in CMakeLists.txt but that doesn't propagate to the installed cmake config. The first patch worked on 3.18; the second patch worked on earlier versions, but not early enough - wasn't compatible with 3.10. The third patch fixed the problem.

We need a way to test this in CI. I was testing these locally with

cmake_minimum_required(VERSION 3.0)
project(test)
add_executable(pugitest test.cpp)
find_package(pugixml)
target_link_libraries(pugitest pugixml)

I believe the CI infra - between Travis and Appveyor - probably has a wide enough gamut of CMake versions for us to validate all of this. If someone could contribute the necessary changes that'd be fantastic...

@zeux
Copy link
Owner Author

zeux commented Dec 22, 2020

List of CMake issues that would need to be covered by this test:

#383
#389
#390
#393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant