Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error messages in case of node unavailability #52

Open
isezen opened this issue Nov 30, 2022 · 0 comments
Open

Better error messages in case of node unavailability #52

isezen opened this issue Nov 30, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@isezen
Copy link

isezen commented Nov 30, 2022

Right now, bazuka node status returns the following output if node is not running:

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: ServerError(hyper::Error(Connect, ConnectError("tcp connect error", Os { code: 111, kind: ConnectionRefused, message: "Connection refused" })))', src/main.rs:371:18
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Instead, it is better to inform user with a message Node Stopped or Node is not running.
@keyvank keyvank changed the title [ FEATURE] bazuka node status Better error messages in case of node unavailability Mar 6, 2023
@keyvank keyvank added enhancement New feature or request good first issue Good for newcomers labels Mar 6, 2023
n1rna added a commit to n1rna/bazuka that referenced this issue Apr 30, 2023
@n1rna
ziesha-network#52 Improve the error message of the node status comman…
069a5c6 
…d in case of connection issues
@n1rna n1rna mentioned this issue Apr 30, 2023
Merged
keyvank pushed a commit that referenced this issue May 3, 2023
@n1rna
#52 Improve the error message of the node status command (#79)
adbcf96 
* #52 Improve the error message of the node status command in case of connection issues

* Add panic handler for all the cli errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@isezen @keyvank