New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LazyPath.path is deprecated #596

Closed

Pyrolistical opened this issue May 15, 2024 · 2 comments · Fixed by #600

Labels

incoming

Contributor

Pyrolistical commented May 15, 2024

In the current pinned version, LazyPath.path is deprecated:
https://github.com/ziglang/zig/blob/3648d7df19642b6902b3f75538a826a322211673/lib/std/Build.zig#L2135-L2136

But it is used throughout the builds:
https://github.com/search?q=repo%3Azig-gamedev%2Fzig-gamedev+.path+language%3AZig++path%3A**%2Fbuild.zig&type=code

hazeycode added the incoming label

Pyrolistical mentioned this issue

Extracted dxc command from samples to zwin32 compile shaders step #599

Merged

Contributor Author

Pyrolistical commented May 18, 2024 •

edited

...and its gone:
ziglang/zig@dee9f82

This issue should be added to #464

Contributor Author

Pyrolistical commented May 18, 2024

I'll get a PR up

Pyrolistical mentioned this issue

Remove deprecated LazyPath.path #600

Merged

hazeycode closed this as completed in #600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment