Field rename does not rename struct initialization's fields

[johan0A]

Zig Version

0.12.0-dev.3245+4f782d1e8

Zig Language Server Version

0.12.0-dev.496+96eddd0

Client / Code Editor / Extensions

vscode

Steps to Reproduce and Observed Behavior

Rename field inside TestStruct, initialize struct using syntax below ⇾ the initialization does not get updated

const TestStruct = struct {
    test_var_renamed: i32, //field was renamed here
};

test "test" {
    const test_struct: TestStruct = .{
        .test_var = 1, //does not get renamed
    };

    const test_struct2: TestStruct = TestStruct{
        .test_var = 1, //does not get renamed
    };

    std.debug.print("{}", .{test_struct});
    std.debug.print("{}", .{test_struct2});
}

Expected Behavior

const TestStruct = struct {
    test_var_renamed: i32, //field was renamed here
};

test "test" {
    const test_struct: TestStruct = .{
        .test_var_renamed = 1, //gets renamed
    };

    const test_struct2: TestStruct = TestStruct{
        .test_var_renamed = 1, //gets renamed
    };

    std.debug.print("{}", .{test_struct});
    std.debug.print("{}", .{test_struct2});
}

Relevant log output

No response

[WillLillis]

I'm also running into this issue using 0.13.0-dev.29+bb19bee. It looks like zls is ignoring the initialization accesses to the struct's fields when it searches for references as part of the renaming request. These references are also missing when using the server's textDocument/reference capability. I'm not super familiar with the language/ zls code base yet, but after a bit of poking around it looks like the references are missed here:

zls/src/features/references.zig

Lines 95 to 135 in 93b7bbd

	fn referenceNode(self: *const Context, tree: Ast, node: Ast.Node.Index) error{OutOfMemory}!void {
	const builder = self.builder;
	const handle = self.handle;
	const node_tags = tree.nodes.items(.tag);
	const datas = tree.nodes.items(.data);
	const token_tags = tree.tokens.items(.tag);
	const starts = tree.tokens.items(.start);
	switch (node_tags[node]) {
	.identifier,
	.test_decl,
	=> {
	const identifier_token = Analyser.getDeclNameToken(tree, node) orelse return;
	if (token_tags[identifier_token] != .identifier) return;
	const child = (try builder.analyser.lookupSymbolGlobal(
	handle,
	offsets.tokenToSlice(tree, identifier_token),
	starts[identifier_token],
	)) orelse return;
	if (builder.decl_handle.eql(child)) {
	try builder.add(handle, identifier_token);
	}
	},
	.field_access => {
	const lhs = try builder.analyser.resolveTypeOfNode(.{ .node = datas[node].lhs, .handle = handle }) orelse return;
	const deref_lhs = try builder.analyser.resolveDerefType(lhs) orelse lhs;
	const symbol = offsets.tokenToSlice(tree, datas[node].rhs);
	const child = (try deref_lhs.lookupSymbol(builder.analyser, symbol)) orelse return;
	if (builder.decl_handle.eql(child)) {
	try builder.add(handle, datas[node].rhs);
	}
	},
	else => {},
	}
	}
	};

If I add a .assign_destructure arm to the switch block, it looks like that matches up with the missing references to the field initializations (I'm still not 100% confident, though). Still working on how to properly add the appropriate information to the references builder, but hopefully this helps narrow down the issue :) Nevermind, definitely not .assign_destructure.

Related #1700