ZLS intellisense suggests duplicate declarations in complex namespace types

[mbartelsm]

Zig Version

0.12.0

Zig Language Server Version

0.12.0

Client / Code Editor / Extensions

VSCode with Zig extension

Steps to Reproduce and Observed Behavior

The following code

const S = struct {
    pub fn foo() void {}
};

const S1 = struct {
    pub const a: i32 = 0;
};

const S2 = struct {
    pub const a: u8 = 0;
};

fn S3(comptime opt: bool) type {
    return if (opt) struct {
        pub usingnamespace S;
        pub usingnamespace S1;
    }
    else struct {
        pub usingnamespace S;
        pub usingnamespace S2;
    };
}

pub fn main() !void {
    _ = S3(true). // <<< Autocomplete here
}

Will produce duplicate suggestions.

If you use more complex branching, every possibility will be added, resulting in even more duplicates

Expected Behavior

I would expect duplicates to be filtered out.

By a duplicate I mean a declaration of matching name and type. I believe there is merit in keeping declarations of matching name but different type as, barring more sophisticated type evaluation, an overview of all the available types is better than a single wrong one.

Alternatively, "unknown" or the most general type (i32 and u8 => Int, or fn () void and fn (bool) !Bar => Fn) could be specified instead

Relevant log output

No response

[Techatrix]

Duplicate of #1041