Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

todo list of make the verifier production usable on aptos #49

Open
5 tasks
nanne007 opened this issue Dec 9, 2023 · 1 comment
Open
5 tasks

todo list of make the verifier production usable on aptos #49

nanne007 opened this issue Dec 9, 2023 · 1 comment

Comments

@nanne007
Copy link
Collaborator

nanne007 commented Dec 9, 2023

Although we had verified the correctness of the verifier.
Still many problems to be resolved to make it usable on aptos mainnet.

  • aptos limit on elments mem usage during a session. see address the issue of too many elements #47
  • the problem of different serialization of bn254 curve point between halo2 and arkworks.
  • to solve the problem above, we have to calculate Y based on X which needs a sqrt function on base field. That's missing on atpos. we implemented it with a pow(u256),
    public fun sqrt_fq(self: &Element<Fq>): Option<Element<Fq>> {
    which has very low efficiency.
  • currently, we implement pow function with pure move,
    fun pow<F>(self: &Element<F>, exp: &vector<u64>): Element<F> {
    which can consume many gas when the power is big. should be optimized.
  • currently, we cannot store a crypto element in state. Had to store them in serialized form. It's inconvenient for developers.
@nanne007
Copy link
Collaborator Author

we will cooperate with devs of aptos to finish the job.
will start from Feb or Mar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant