settings: Add synchronization in deactivating users. #29926
+28
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @zulip/server-settings members, this pull request was labeled with the "area: settings UI" label, so you may want to check it out! |
roanster007
force-pushed
the
iss-29891
branch
4 times, most recently
from
50de61e
to
2a511b6
Compare
Previously, when a user is activated or deactivated through the "Organization Settings", the corresponding tables of deactivated or activated users are not updated until the modal is re rendered. This is fixed by updating the table with new entries every time a new event to either activate or deactivate the user is received. Fixes zulip#29891
|
So I think this might be better tabled in favor of our plans to merge the different panels? @sahil839 FYI for thoughts on that. |
|
Yes, that would be better. That PR was close to completion with a couple of refactors remaining, I will check what is the current status of that PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when a user is activated or deactivated through the "Organization Settings", the corresponding tables of deactivated or activated users are not updated until the modal is re rendered.
This is fixed by updating the table with new entries every time a new event to either activate or deactivate the user is received.
Fixes #29891
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: