Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix action column in deactivated users table. #29894

Open
nimishmedatwal opened this issue Apr 30, 2024 · 6 comments · May be fixed by #29986
Open

Fix action column in deactivated users table. #29894

nimishmedatwal opened this issue Apr 30, 2024 · 6 comments · May be fixed by #29986

Comments

@nimishmedatwal
Copy link
Collaborator

nimishmedatwal commented Apr 30, 2024

Currently when admin chooses to reactivate user from Actions column in deactivated users table and then clicks on any other column it shows action as unknown (sometimes it shows yesterday, or a date).
image
image
image

CZO thread

@zulipbot
Copy link
Member

Hello @zulip/server-settings members, this issue was labeled with the "area: settings UI" label, so you may want to check it out!

@dhruv-goyal-10
Copy link
Collaborator

@nimishmedatwal @alya
The values like unknown, yesterday or date are actually the last_active_date values for that user.

The UI is rendered in a way such that, as soon as the user gets active the last_active_date is also shown in the table. That's why when we are reactivating and applying any filter, the components gets refreshed and we are seeing those values.

How do you want me to proceed?

  • Add last_active_date column in deactivated users table, just like users table, or
  • Remove that last_active_date value even after the user is reactivated.

@alya
Copy link
Contributor

alya commented May 6, 2024

Let's do this -- thanks for checking.

Remove that last_active_date value even after the user is reactivated.

@dhruv-goyal-10
Copy link
Collaborator

@alya There is one issue in users table, which is similar to deactivated users table.

On deactivation, since the user isn't active, after sorting, the components gets refreshed and last_active_date isn't shown.

image

@dhruv-goyal-10
Copy link
Collaborator

@zulipbot claim

dhruv-goyal-10 added a commit to dhruv-goyal-10/zulip that referenced this issue May 7, 2024
@dhruv-goyal-10 dhruv-goyal-10 linked a pull request May 7, 2024 that will close this issue
@alya
Copy link
Contributor

alya commented May 7, 2024

I think it would be best to continue showing the last active time. I guess second best would be to show something like Unknown, and of course the UI in result in your screenshot does not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants