Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start new conversation button's tooltip not updating in DM narrow when direct messages are disabled. #29916

Open
sayamsamal opened this issue May 1, 2024 · 1 comment · May be fixed by #30132
Labels
area: compose (UI & widgets) Scheduled messages, giphy, send later, etc. area: popovers Popovers, including general message actions. bug help wanted

Comments

@sayamsamal
Copy link
Collaborator

When an organization disables direct messages, the "Start new conversation" button's tooltip no longer updates when a user navigates to the direct messages; instead it retains whatever tooltip was present on it from the previous view/narrow.

image

We want the tooltip to show "New direct message (x)" as expected.

Note

A user can always DM themselves or a bot, even when direct messages are disabled in an org — the reason why we don't disable the "Start new conversation" button. (#28412)

CZO discussion

Steps to reproduces:
Considering direct messages are disabled for the org (Settings > Organization permissions > Other permissions)

  1. Go to a stream, #design for example and hover over the "Start new conversation" button — it shows "New topic (c)"
  2. Go to direct message, hover of the "Start new conversation" button — it still shows "New topic (c)", whereas we expect it to show "New direct message (x)"
@sayamsamal sayamsamal added bug help wanted area: popovers Popovers, including general message actions. area: compose (UI & widgets) Scheduled messages, giphy, send later, etc. labels May 1, 2024
kennethnrk added a commit to kennethnrk/zulip that referenced this issue May 18, 2024
@kennethnrk
Copy link
Collaborator

@sayamsamal I've opened a PR for this issue. Please review it when you get the chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: compose (UI & widgets) Scheduled messages, giphy, send later, etc. area: popovers Popovers, including general message actions. bug help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants