Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Position compose typeaheads near cursor #29974

Open
alya opened this issue May 6, 2024 · 1 comment · May be fixed by #30141
Open

Position compose typeaheads near cursor #29974

alya opened this issue May 6, 2024 · 1 comment · May be fixed by #30141
Labels
area: compose (typeahead) Compose typeahead content and design help wanted priority: high

Comments

@alya
Copy link
Contributor

alya commented May 6, 2024

As noted in #29882 (comment), we should place compose box typeahead near the cursor.

We should be able to to use a library like textarea-caret to get the current caret position.

Blockers:
@alya alya added priority: high area: compose (typeahead) Compose typeahead content and design labels May 6, 2024
@alya alya mentioned this issue May 6, 2024
Merged
adnan-td added a commit to adnan-td/zulip that referenced this issue May 20, 2024
@adnan-td
typeahead: Fix typeahead position using carets.
0cfa162 
Utilize textarea-caret package to offset the typeahead position.
Now typeahead is close to the cursor.

Fixes: zulip#29974
@adnan-td adnan-td linked a pull request May 20, 2024 that will close this issue
Open
12 tasks
@adnan-td
Copy link
Collaborator

The position of the typeahead in now near the cursor in #30141. Utilized textarea-caret library as suggested.

adnan-td added a commit to adnan-td/zulip that referenced this issue May 22, 2024
@adnan-td
typeahead: Fix typeahead position using carets.
bc18211 
Utilize textarea-caret package to offset the typeahead position.
Now typeahead is close to the cursor.

Fixes: zulip#29974
adnan-td added a commit to adnan-td/zulip that referenced this issue May 26, 2024
@adnan-td
typeahead: Fix typeahead position using carets.
9ca1c9e 
Utilize textarea-caret package to offset the typeahead position.
Now typeahead is close to the cursor.

Fixes: zulip#29974
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: compose (typeahead) Compose typeahead content and design help wanted priority: high
Projects
Zulip 9.0 priorities
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use textarea-caret to place compose box typeahead near the cursor adnan-td/zulip
2 participants
@alya @adnan-td