Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] popover: Add options to confirm mark as read modal. #30041

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[WIP] popover: Add options to confirm mark as read modal. #30041

wants to merge 2 commits into from
+40 −2

Conversation

PieterCK
Copy link
Collaborator

This change sets up confirm_mark_all_as_read.hbs
modal for extended feature to add options for user to narrow down what kind of messages they want to
mark as unread instead of just mark all as unread.

Fixes: #30025

Screenshots and screen captures:

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@zulipbot
Copy link
Member

Hello @PieterCK, it seems like you have referenced #30025 in your pull request description, but you have not referenced them in your commit message description(s). Referencing an issue in a commit message automatically closes the corresponding issue when the commit is merged, which makes the issue tracker easier to manage.

Please run git commit --amend in your command line client to amend your commit message description with Fixes #30025..

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146
Author: zulipbot
Date:   Sat Mar 18 13:42:40 2017 -0700

    pull requests: Check PR commits reference when issue is referenced.

    Fixes #51.

To learn how to write a great commit message, please refer to our guide.

@PieterCK PieterCK changed the title popover: Add options to confirm mark as read modal. [WIP] popover: Add options to confirm mark as read modal. May 10, 2024
@PieterCK
popover: Change mark as read confirmation modal.
37a20a2 
This change sets up confirm_mark_all_as_read.hbs
modal for extended feature to add options for user
to narrow down what kind of messages they want to
mark as unread instead of just mark all as unread.
@PieterCK PieterCK force-pushed the issue-30025-add-options-for-marked-as-read-modal branch from 71b5915 to 713e636 Compare May 10, 2024 10:17
@zulipbot zulipbot added size: M and removed size: S labels May 10, 2024
@PieterCK
unread_ops: Add logic to confirmation modal for mark as read.
bbe4b5a 
Add new logics to enable the capability of marking
as read to only the selected type of messages
specified in the confirmation modal for marking
messages as read.
@PieterCK PieterCK force-pushed the issue-30025-add-options-for-marked-as-read-modal branch from 713e636 to bbe4b5a Compare May 11, 2024 13:04
@zulipbot
Copy link
Member

Heads up @PieterCK, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
has conflicts size: M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add options for which messages are marked as read
2 participants
@PieterCK @zulipbot