Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options for which messages are marked as read #30025

Open
2 tasks
alya opened this issue May 9, 2024 · 6 comments · May be fixed by #30041
Open
2 tasks

Add options for which messages are marked as read #30025

alya opened this issue May 9, 2024 · 6 comments · May be fixed by #30041
Labels
area: popovers Popovers, including general message actions. help wanted new feature A proposed new feature for the product

Comments

@alya
Copy link
Contributor

alya commented May 9, 2024 •
edited

As discussed on CZO, it can be helpful to mark some categories of messages as read, rather than all messages. To implement this, we can add an option for which messages are marked as read to the confirmation modal. Specifically, we can:

  • Rename "Mark all messages as read" -> "Mark messages as read" in the menu. (We should think about how to do a better job of hinting that there will be a choice to make.)
  • Change the confirmation modal to:

Choose messages to mark as read

Which messages do you want to mark as read? This action cannot be undone.

Muted topics
Topics I don't follow <- Default option in dropdown
All messages

N messages will be marked as read. <- Changes if selection is changed

[Cancel] [Confirm]

The help center (https://zulip.com/help/marking-messages-as-read#mark-all-messages-as-read) will need to be updated accordingly.

Current confirmation modal:

Screenshot 2024-05-08 at 17 45 42@2x

CZO thread
@alya alya added help wanted new feature A proposed new feature for the product area: popovers Popovers, including general message actions. labels May 9, 2024
@PieterCK
Copy link
Collaborator

PieterCK commented May 9, 2024 •
edited

Hello, I'm interested in working on this issue. I've already found the relevant area in the code base (confirm_mark_all_as_read.hbs & unread_ops.js) and played around with the new confirmation modal.

first draft of the new mark as read confirmation modal:
image

will open a draft PR for implementation feedbacks in a bit

@PieterCK
Copy link
Collaborator

PieterCK commented May 9, 2024

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented May 9, 2024

Hello @PieterCK, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

@PieterCK
Copy link
Collaborator

PieterCK commented May 9, 2024 •
edited

Hello @PieterCK, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

And as for the statuses of my projects, all are waiting for reviews: checkin

@PieterCK PieterCK linked a pull request May 10, 2024 that will close this issue
Draft
12 tasks
@shubham-padia
Copy link
Member

shubham-padia commented May 13, 2024 •
edited

Muted topics <- Default option in dropdown

The original issue description mentions dropdown. Unless it has been discussed elsewhere, might be wise to wait for confirmation on your draft.

Also, there's ongoing discussion on the topic here. @alya might be able to confirm whether the issue is ready to be worked on or not? So as to avoid rework in case the requirements change.

@PieterCK
Copy link
Collaborator

PieterCK commented May 13, 2024 •
edited

Understood, thanks for the heads-up. I'll put the draft PR on hold for now. Please let me know when we have the final specs and the issue is ready to be worked on. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: popovers Popovers, including general message actions. help wanted new feature A proposed new feature for the product
Projects
Zulip 9.0 priorities
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] popover: Add options to confirm mark as read modal. PieterCK/zulip
4 participants
@alya @shubham-padia @zulipbot @PieterCK