Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify instructions for moving topics/messages #30055

Open
alya opened this issue May 10, 2024 · 1 comment · May be fixed by #30064
Open

Simplify instructions for moving topics/messages #30055

alya opened this issue May 10, 2024 · 1 comment · May be fixed by #30064
Assignees
@iks1
Labels
area: popovers Popovers, including general message actions. help wanted in progress priority: high

Comments

@alya
Copy link
Contributor

alya commented May 10, 2024 •
edited

We should remove the "Select a channel below or change topic name." instruction from the "Move topic" / "Move messages" modals. It's not necessary, and can be confusing when the user doesn't have permissions to change the channel or the topic name.

  1. On the "Move topic" modal, we should just drop this line.
  2. On the "Move messages" modal, we should replace this line with:

Move messages to:

Current modals

Screenshot 2024-05-10 at 13 23 57@2x

Screenshot 2024-05-10 at 13 23 25@2x

CZO thread
@alya alya added help wanted priority: high area: popovers Popovers, including general message actions. labels May 10, 2024
@iks1
Copy link
Collaborator

iks1 commented May 11, 2024

@zulipbot claim!

iks1 added a commit to iks1/zulip that referenced this issue May 12, 2024
@iks1
Modal: Simplified instructions for moving topics/messages
eec1488 
Modified the `Select a channel below or change topic name.` instruction in `move topics/move messages` modal.
It's not necessary and can be confusing when user does not have permissions to change the channel and topic name.

1) On the `Move topic` modal, dropped the line
2) On the `Move messages` modal, replaced the line with `Move messages to:`

Fixes zulip#30055
@iks1 iks1 linked a pull request May 12, 2024 that will close this issue
Open
12 tasks
iks1 added a commit to iks1/zulip that referenced this issue May 13, 2024
@iks1
modal: Simplify instructions for moving topics/messages.
004b576 
Modified the `Select a channel below or change topic name.`
instruction in `move topics/move messages` modal.
It's not necessary and can be confusing when user does not
have permissions to change the channel and topic name.

1) On the `Move topic` modal, dropped the line
2) On the `Move messages` modal, replaced the line with `Move messages to:`

Fixes zulip#30055
iks1 added a commit to iks1/zulip that referenced this issue May 13, 2024
@iks1
popovers: Simplify instructions for moving topics/messages.
870e3bd 
Modified the `Select a channel below or change topic name.`
instruction in `move topics/move messages` modal.
It's not necessary and can be confusing when user does not
have permissions to change the channel and topic name.

1) On the `Move topic` modal, dropped the line
2) On the `Move messages` modal, replaced the line with `Move messages to:`

Fixes zulip#30055
iks1 added a commit to iks1/zulip that referenced this issue May 14, 2024
@iks1
popovers: Simplify instructions for moving topics/messages.
d4c87a7 
Modified the `Select a channel below or change topic name.`
instruction in `move topics/move messages` modal.
It's not necessary and can be confusing when user does not
have permissions to change the channel and topic name.

1) On the `Move topic` modal, dropped the line
2) On the `Move messages` modal, replaced the line with `Move messages to:`

Fixes zulip#30055
iks1 added a commit to iks1/zulip that referenced this issue May 17, 2024
@iks1
popovers: Simplify instructions for moving topics/messages.
58fe1de 
Modified the `Select a channel below or change topic name.`
instruction in `move topics/move messages` modal.
It's not necessary and can be confusing when user does not
have permissions to change the channel and topic name.

1) On the `Move topic` modal, dropped the line
2) On the `Move messages` modal, replaced the
   line with `Move messages to:`

Fixes zulip#30055.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iks1 iks1

Labels
area: popovers Popovers, including general message actions. help wanted in progress priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

popovers: Simplify instructions for moving topics/messages iks1/zulip
3 participants
@alya @zulipbot @iks1