Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for --add-modules generally #32

Open
Vampire opened this issue Apr 6, 2018 · 1 comment
Open

Support for --add-modules generally #32

Vampire opened this issue Apr 6, 2018 · 1 comment

Comments

@Vampire
Copy link

Vampire commented Apr 6, 2018

Please support specifying additional modules that are added with --add-modules via JavaModuleHacks and not only for extra test modules.

Of course you could also just requires them in your module descriptor, but I'd consider that even hackier than via the JavaModuleHacks, as your module does not actually require the given module.
One example is netty with a JRE runtime that was produced with javapackager.
If you use it with a full JRE all works fine, if you use it with the "custom" JRE runtime, you get a class not found exception for sun.misc.Unsafe unless you either require jdk.unsupported in your own module descriptor or use --add-modules jdk.unsupported.

@Vampire
Copy link
Author

Vampire commented Apr 6, 2018

Other examples are async.http.client which needs org.slf4j or com.fasterxml.jackson.databind and jasperreports which need java.sql.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant