Update to WinUI 2.7 #976
Update to WinUI 2.7 #976
Conversation
nuget-deps: bump Microsoft.AppCenter.Crashes in /src/Notepads (0x7c13#959) Bumps Microsoft.AppCenter.Crashes from 4.1.0 to 4.4.0. --- updated-dependencies: - dependency-name: Microsoft.AppCenter.Crashes dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jiaqi Liu <jackil@microsoft.com>
… 3.0)." This reverts commit 78ba473.
…e (WinUI 3.0)."" This reverts commit 9208061.
|
The errors in App.xaml.cs: |
|
Ah yes, forgot to tell that the Navigation Item that doesn't open when you open settings can be opened by clicking on it. Just fails when you open the settings. |
|
I will be working on the visual update by EOY. I will wait for WinUI 2.x to get mature before doing so. |
|
It's ok. If you need some help, tell me. WinUI 3 by the moment isn't avaliable for UWP or it's very unestable, so better wait. |
|
Delete all custom style and update UI: |
|
@BobbyESP Hai. how have you seen:)
FYI, It's a not bug but specification. so, need to load the page in NaviView_Loaded() or Page_Loaded() Instead, use the IsSelected flag to receive change events on ItemSelected. but this app uses ItemInvoked() this do not trigger selection changing event from IsSelected = true. https://github.com/JasonStein/Notepads/blob/master/src/Notepads/Views/Settings/SettingsPage.xaml#L18 |
|
Ohh, i see! |
|
I am waiting for WinUI v2.8 stable release before looking into upgrading the UX. Are there any issues you find with v2.8 prerelease? |
|
ah. I don't have the problem I saw in WinUI prerelease in UI Control, but I found a lot in WerbView2 regardless of whether you are using WebView2. Also, due to that issue, projects that download WinUI 2.8 prerelease may fail in store submissions. It may be a big help, why not use WinUI2.7 stable ver? |
|
And when updating to WinUI 2.7 or later, the IsSelect property does not trigger the ItemInvoked event. It still triggers SelectionChanged, so you need to navigate to the initial page when loading the settings page. You will find it during the migration. |
|
There are some other UI issues bringing by the v2.7 release, I cannot remmeber the exact but it has been disscussed earlier. The rolling speed of the WinUI 2 and 3 releases are much slower than my expectation:( |
|
Guys It has been over two years now. When will this UI update take place? |
|
The owner hesitates to move to WinUI2.8 or 3.0 because it would bring more WinUI-side issues. |
|
Damn. |
Are these issues are still relevant as for today? WinUI v2.8 stable release came out quite a long time ago. |
|
I said the same thing to them. lol. |
App style update
PR Type
What kind of change does this PR introduce?
Bugs known