Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Handle mutual close in state DATA_WAIT_FOR_FUNDING_CONFIRMED #723

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

[WIP] Handle mutual close in state DATA_WAIT_FOR_FUNDING_CONFIRMED #723

wants to merge 10 commits into from

Conversation

pm47
Copy link
Member

@pm47 pm47 commented Sep 25, 2018

This is a clone of #358 which apparently lost track of the remote branch (unknown repository).

anton and others added 6 commits January 4, 2018 12:03
Can initiate and appropriately react to a mutual closing in `DATA_WAI…
4c65ceb 
…T_FOR_FUNDING_CONFIRMED` state
Rebase
55314e8
Merge remote-tracking branch 'origin/early-mutual-close' into early-m…
77787f0 
…utual-close

# Conflicts:
#	eclair-core/src/main/scala/fr/acinq/eclair/channel/Channel.scala
#	eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelTypes.scala
@pm47
merged from master
2381c18
@pm47
temporarily disable CMD_CLOSE test in WAIT_FOR_FUNDING_CONFIRMED
6d28b95
@pm47
made encoding backward compatible
c537266
@pm47
Copy link
Member Author

pm47 commented Sep 25, 2018

c537266 that's your favorite bug @btcontract

@pm47
Copy link
Member Author

pm47 commented Sep 26, 2018

@btcontract I actually got bitten too! see 21c37e4

@pm47
Copy link
Member Author

pm47 commented Sep 27, 2018

There are several more problems with this PR:

  • mutual close should also be supported in WAIT_FOR_FUNDING_LOCKED
  • the reconnection logic should handle the case where we have already sent a shutdown
  • I don't really like the fact that sending two CMD_CLOSE results in a force close; maybe we should rely on a feature bit to announce whether or not we support early close (cc @sstone)

@pm47 pm47 changed the title Handle mutual close in state DATA_WAIT_FOR_FUNDING_CONFIRMED [WIP] Handle mutual close in state DATA_WAIT_FOR_FUNDING_CONFIRMED Sep 27, 2018
@pm47 pm47 assigned sstone and unassigned sstone Oct 23, 2018
@pm47 pm47 added WIP and removed WIP labels Apr 10, 2019
@pm47 pm47 mentioned this pull request Feb 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pm47 @sstone