Make blockheight/fees flows non-nullable #493
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This guarantees that the peer will never block before processing a channel message, but implies that: - updating these values is done outside of the peer - the peer cannot be instantiated before a connection to electrum has been established
pm47
commented
Jun 28, 2023
| @@ -188,20 +187,6 @@ class Peer( | |||
| val swapInAddress: String = nodeParams.keyManager.swapInOnChainWallet.address.also { swapInWallet.addAddress(it) } | |||
|
|
|||
| init { | |||
| launch { | |||
| watcher.client.notifications.filterIsInstance<HeaderSubscriptionResponse>() | |||
There was a problem hiding this comment.
There was a race condition here between establishing the connection to electrum (which happens outside of the peer), and subscribing to HeaderSubscriptionResponse.
If the connection to electrum is very fast, tje peer will miss the initial HeaderSubscriptionResponse and then have to wait for the next block.
Same race condition applies for feerates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This guarantees that the peer will never block before processing a channel message, but implies that: