Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added scalers for batch processing #221

Open
wants to merge 1 commit into
base: masterr
Choose a base branch
from
Open

added scalers for batch processing #221

wants to merge 1 commit into from

Conversation

kritim13
Copy link
Collaborator

  1. Batch Standard Scaler
  2. Batch Label Encoder

isaacmg
isaacmg reviewed Dec 23, 2020
View reviewed changes
Copy link
Collaborator

@isaacmg isaacmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that linting was failing. Do you want me to fix that for you? Also is there a way to test that these in the end produce the same results as if we just ran the model with the normal scaling? That would be useful to just verify maybe with a integration test where we log the results of these both with the standard method and these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaacmg isaacmg isaacmg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kritim13 @isaacmg