Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ImageViewer Navigation Index label #15731

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

bluelovers
Copy link
Contributor

Description

  • a simple description of what you're trying to accomplish
  • a summary of changes in code
  • which issues it fixes, if any

Screenshots/videos:

image

Checklist:

@w-e-w
Copy link
Collaborator

w-e-w commented May 8, 2024

I don't like it
it gets into the way of portrait images
image
if this is implemented I think it should show only on Hover and


it's been off center also really bothers me

there's also no point of showing the text when there's only one image
in my opinion, it's also isn't that much useful unless you're dealing with lots of images


even if this PR is straightforward that mostly things can be conveyed through a screenshot
you should still give a simple description
how much time would it take one minute?


and it's not a good idea to use images that can be considered NSFW for work or screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants