Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Roblox and Minecraft to Blocked Services. #3092

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

muhepd
Copy link

@muhepd muhepd commented May 6, 2021

Updated blocked.go - Added Roblox and Minecraft Services.
Roblox.com will block all instances of Roblox game in any platform.
Minecraft.com will block all instances of Minecraft game in any platform.

I created a custom rule where I blocked both domains with all its subdomains and it works as expected. I just would like them to be added to the block services switch so it is easier and faster to control and apply to particular clients.

Updated blocked.go - Added Roblox and Minecraft Services.
@ameshkov ameshkov added this to the v0.107.0 milestone May 7, 2021
@stedon81
Copy link

stedon81 commented May 9, 2021

Hi muhepd,
sorry, I'm new here and have never worked for/with AdGuard source code.
However, I stumpled over the comment above the array that you intent to extend:

// Keep in sync with: // client/src/helpers/constants.js // client/src/components/ui/Icons.js

I guess you will have to modify those two files, too, in order to get your pull request merged.
Thanks for your contribution! Will seek to also get some more services in (deezer would be important for my part)

Regards,
stedon81

@ghost
Copy link

ghost commented May 13, 2021

minecraft.com is not actual minecraft domain, maybe you mean https://minecraft.net/ ?

@muhepd
Copy link
Author

muhepd commented May 14, 2021

minecraft.com not is actual minecraft domain, may be you mean https://minecraft.net/ ?

Hi Andreypfau, you are right, thank you!

Copy link
Author

@muhepd muhepd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated minecraft.com to minecraft.net

@muhepd
Copy link
Author

muhepd commented May 14, 2021

Hi muhepd,
sorry, I'm new here and have never worked for/with AdGuard source code.
However, I stumpled over the comment above the array that you intent to extend:

// Keep in sync with: // client/src/helpers/constants.js // client/src/components/ui/Icons.js

I guess you will have to modify those two files, too, in order to get your pull request merged.
Thanks for your contribution! Will seek to also get some more services in (deezer would be important for my part)

Regards,
stedon81

Hi stedone81,

Thanks for your feedback,

I updated constants.js, however I'm having issues with Icons.js, I don't know how to define the path.

@ghost
Copy link

ghost commented May 14, 2021

if you want to list all the addresses used for Minecraft, I advise you to study the API documentation: https://wiki.vg/Main_Page
There are many different endpoints APIs with different domains for different services that relate to Minecraft

@stale
Copy link

stale bot commented Sep 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 19, 2021
@stale stale bot removed the wontfix label Sep 30, 2021
@ainar-g ainar-g modified the milestones: v0.107.0, v0.108.0 Dec 13, 2021
@tomcoleman
Copy link

is there a guide on how todo this ?

@dioey
Copy link

dioey commented Jan 21, 2022

is there a guide on how todo this ?

for blocking roblox add this on Custom filtering rules
||roblox.com^$important
||rbxcdn.com^$important
||rbxtrk.com^$important
||roblox.plus^$important

@tomcoleman
Copy link

is there a guide on how todo this ?

for blocking roblox add this on Custom filtering rules ||roblox.com^$important ||rbxcdn.com^$important ||rbxtrk.com^$important ||roblox.plus^$important

what does $important do? as thats not in any of the examples

@dioey
Copy link

dioey commented Jan 24, 2022

is there a guide on how todo this ?

for blocking roblox add this on Custom filtering rules ||roblox.com^$important ||rbxcdn.com^$important ||rbxtrk.com^$important ||roblox.plus^$important

what does $important do? as thats not in any of the examples

that adguard syntac i cant explain well you should see this https://kb.adguard.com/en/general/dns-filtering-syntax and this one https://github.com/AdguardTeam/AdGuardHome/wiki/Hosts-Blocklists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants