Added duplicate rewrite entry check (partially fixes #4585) #4586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loop over existing entries and return an error if the entry already exists
|
Thank you, but I'd like to put this on hold, since the HTTP API and its code will be fully rewritten during the v0.108 cycle. Also, correct me if I'm wrong, but this won't check for duplicates in the data that is currently being sent? |
|
This only accounts for sending one single rewrite because the current implementation doesn't work for multiple rewrites. 🤷🏻 |
|
Ah, you're right. I've been thinking ahead of myself 😅. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loop over existing entries and return an error if the entry already exists