MultipartFormData ContentHeaderEncoding UTF-8 #3754
Conversation
|
Thanks for the PR! Please follow the PR template to inform why you'd like to see this change and how applicable it is for all Alamofire users. |
Thx for the quick reply, just opened a issues #3755 to describe the problem |
|
I guess I don't understand the need here. UTF-8 is already used for the filename encoding we get the from the system, so why would a less capable encoding be necessary? And I'm not sure Additionally, a change like this requires both updated documentation as well as tests. I can write the documentation if you can't, but tests are required as part of this change. |
jshier
changed the title
Hey @jshier thx for the feedback and sorry for the late reply. Currently it look's like we use use iso-8859-1 by default and not UTF-8 for the MultipartFormData ContentHeaderEncoding. Maybe everywhere else but not for MultipartFormData. 🤔 |
| if let fileName = fileName { | ||
| let encodingPrefix: String | ||
| if let encoding = encoding { | ||
| encodingPrefix = "*=\(encoding.rawValue)" |
There was a problem hiding this comment.
GIST, optional encoding Info with one of:
*=UTF-8
default is without only
=
There was a problem hiding this comment.
it look's like its not the client but the server, the server falls back to iso-8859-1 if there is only =.
There was a problem hiding this comment.
so the server uses the UTF-8 String but only with iso-8859-1 char set so there are unknown characters. With *=UTF-8 we can tell the server explicitly that we are using UTF-8.
There was a problem hiding this comment.
removed iso-8859-1 and added some tests
the change is optional and does not change current behaviour
apps4everyone
changed the title
Try to fix #3755