Add a test function to detect a memory leak if it it happened #3859
+35
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jshier
requested changes
May 11, 2024
| /// - object: The testing object for each class. | ||
| /// - file: Which file that failure test happens. | ||
| /// - line: Which line that failure test happens. | ||
| @available(iOS 13.0, macOS 10.15, tvOS 13.0, *) |
There was a problem hiding this comment.
Can you add explicit watchOS and visionOS support as well? I think the other OSes are on their own.
| checkMemoryLeaksIfApplicable(interceptor) | ||
| } | ||
|
|
||
| private func checkMemoryLeaksIfApplicable(_ object: AnyObject, file: StaticString = #file, line: UInt = #line) { |
There was a problem hiding this comment.
Seems like this should just live in the BaseTestCase to allow for all tests to use it. And given we can't test back before iOS 13 anyway, I'm not sure the IfApplicable is really necessary here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals ⚽
Follow up from #3766, I create a test function to check that is
RequestInterceptorhas a memory leak or not. It's becoming this pull request because it could be used with other places as well.Implementation Details 🚧
checkMemoryLeaksinBaseTestCaseso that all subclassed test classes can use this function.InterceptorTestsclass.Example of memory leaks (It's just fake from me):
