Limit amount of transactions which clients verify in parallel #2970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljedrz
reviewed
Jan 4, 2024
ljedrz
reviewed
Jan 4, 2024
ljedrz
reviewed
Jan 4, 2024
ljedrz
reviewed
Jan 4, 2024
ljedrz
reviewed
Jan 4, 2024
ljedrz
reviewed
Jan 4, 2024
ljedrz
reviewed
Jan 4, 2024
vicsn
changed the title
raychu86
reviewed
Feb 10, 2024
| use tokio::task::JoinHandle; | ||
| use tokio::{task::JoinHandle, time::sleep}; | ||
|
|
||
| const VERIFICATION_CONCURRENCY_LIMIT: usize = 6; // 8 deployments of MAX_NUM_CONSTRAINTS will run out of memory. |
There was a problem hiding this comment.
Should this be dynamic based on your machine?
How much memory was this estimation based on?
There was a problem hiding this comment.
This was based on the Clients: 16GB of memory requirement in the snarkOS README. Please confirm if you want me to make it a dynamic value from a cli flag.
Sidenote: given our syncing issues I understood the CPU/memory requirements need to go up anyway.
howardwu
added
the
post-launch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Our clients can and do run out of memory, probably because they have no limit on how many transactions they verify in parallel. This PR proposes to queue them (just like the validator does in
Consensus) and limit how much parallel verification we do.We can do a lot of clever things to increase the processing speed, like check how many constraints the incoming transactions have, await on a channel to rapidly start verifying, but the focus for now is simplicity and safety.
Test Plan
Related PRs
Implicitly assumes we have https://github.com/AleoHQ/snarkVM/pull/2271 to limit size of transactions coming through.
And this would help to minimize the overhead of transaction verification when syncing blocks with already seen transactions: https://github.com/AleoHQ/snarkVM/pull/2270