Smooth out sync-to-tip #3170
Draft
Smooth out sync-to-tip #3170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR allows syncing nodes to start processing peer certificates slightly earlier. Previously, the syncing node needed to be synced up in order to be processing incoming batch certificates. Which puts the node behind all the peers, who should have already constructed new rounds past the last commit. This causes a cycle of lagging just out of reach of the latest round and preventing the node from quickly rejoining consensus. Breaking the cycle relies on the node and message timing such that it can fetch the certificates before new ones can be formed on the network.
The change here allows the node to start processing certificates 1 block earlier, in preparation of reaching tip.